Skip to content

Commit 9c712cc

Browse files
authored
fix(eks): incorrect version of aws-node-termination-handler (#19510)
A previous [PR](#18841) upgraded the version of `aws-node-termination-handler`. However, the version contained in the change, 1.14.0, refers to the `appVersion` field and not the `version` field. This change upgrades it to the latest available `version`, 0.18.0, as shown by the command: ``` $ helm search repo aws-node-termination-handler NAME CHART VERSION APP VERSION DESCRIPTION eks/aws-node-termination-handler 0.18.0 1.16.0 A Helm chart for the AWS Node Termination Handler. ``` ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent fd1fff9 commit 9c712cc

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/@aws-cdk/aws-eks/lib/cluster.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -946,7 +946,7 @@ abstract class ClusterBase extends Resource implements ICluster {
946946
if (!this._spotInterruptHandler) {
947947
this._spotInterruptHandler = this.addHelmChart('spot-interrupt-handler', {
948948
chart: 'aws-node-termination-handler',
949-
version: '1.14.1',
949+
version: '0.18.0',
950950
repository: 'https://aws.github.io/eks-charts',
951951
namespace: 'kube-system',
952952
values: {

packages/@aws-cdk/aws-eks/test/integ.eks-cluster.expected.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -2690,7 +2690,7 @@
26902690
},
26912691
"Release": "ksclustertestclusterchartspotinterrupthandlerf41ba997",
26922692
"Chart": "aws-node-termination-handler",
2693-
"Version": "1.14.1",
2693+
"Version": "0.18.0",
26942694
"Values": "{\"nodeSelector\":{\"lifecycle\":\"Ec2Spot\"}}",
26952695
"Namespace": "kube-system",
26962696
"Repository": "https://aws.github.io/eks-charts",

0 commit comments

Comments
 (0)