Skip to content

Commit 97e9ea0

Browse files
authored
chore(eks): remove duplicate test case (#29814)
### Reason for this change The removed case `'throws when a core construct is added as cdk8s chart'` is the same as `'throws when a non cdk8s chart construct is added as cdk8s chart'`. ### Description of changes Removed duplicates. ### Description of how you validated changes Just removed the case. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent a7384c2 commit 97e9ea0

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

packages/aws-cdk-lib/aws-eks/test/cluster.test.ts

-14
Original file line numberDiff line numberDiff line change
@@ -350,20 +350,6 @@ describe('cluster', () => {
350350
expect(() => cluster.addCdk8sChart('chart', someConstruct)).toThrow(/Invalid cdk8s chart. Must contain a \'toJson\' method, but found undefined/);
351351
});
352352

353-
test('throws when a core construct is added as cdk8s chart', () => {
354-
const { stack } = testFixture();
355-
356-
const cluster = new eks.Cluster(stack, 'Cluster', {
357-
version: CLUSTER_VERSION,
358-
prune: false,
359-
});
360-
361-
// create a plain construct, not a cdk8s chart
362-
const someConstruct = new Construct(stack, 'SomeConstruct');
363-
364-
expect(() => cluster.addCdk8sChart('chart', someConstruct)).toThrow(/Invalid cdk8s chart. Must contain a \'toJson\' method, but found undefined/);
365-
});
366-
367353
test('cdk8s chart can be added to cluster', () => {
368354
const { stack } = testFixture();
369355

0 commit comments

Comments
 (0)