Skip to content

Commit 960d14a

Browse files
authored
chore(prlint): dismissed reviews should not count as requested changes (#26552)
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent cb97232 commit 960d14a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tools/@aws-cdk/prlint/lint.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ export class PullRequestLinter {
358358
);
359359
const communityRequestedChanges = reviews.data.some(
360360
review => this.getTrustedCommunityMembers().includes(review.user?.login ?? '')
361-
&& review.state !== 'APPROVED', // community members cannot request changes
361+
&& review.state === 'COMMENTED', // community members can only approve or comment
362362
);
363363
const communityApproved = reviews.data.some(
364364
review => this.getTrustedCommunityMembers().includes(review.user?.login ?? '')

tools/@aws-cdk/prlint/test/lint.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,7 @@ describe('integration tests required on features', () => {
743743
mockListReviews.mockImplementation(() => {
744744
return {
745745
data: [
746-
{ id: 1111122223, user: { login: 'pahud' }, state: 'COMMENT' },
746+
{ id: 1111122223, user: { login: 'pahud' }, state: 'COMMENTED' },
747747
],
748748
};
749749
});

0 commit comments

Comments
 (0)