You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(ec2): fixing vpc endpoint pattern for ecr and ecr docker (#31434)
### Issue # (if applicable)
Closes #.
Internal Tracking ticket P150271569
### Reason for this change
Expected Endpoints for ECR in some isolated regions are as below
gov.ic.hci.csp.us-isof-name.ecr.api,
gov.ic.hci.csp.us-isof-name.ecr.dkr,
uk.adc-e.cloud.eu-isoe-name.ecr.api,
uk.adc-e.cloud.eu-isoe-name.ecr.dkr,
### Description of changes
As discussed with the ECR Service team, endpoints for the service are being generated in reverse order of the domain suffix.
Since some of the endpoints for other services are still using `com.amazonaws` , added fix only for the partitions and service(ECR) flagged.
Cannot do for cn regions on the basis of suffix as both regions have different services under exceptions.
### Description of how you validated changes
Added unit test for validation of endpoint, keeping the region names as `us-isoe-test-1` as the regions are in build stage and could be confidential.
No changes to integration test as the fix is for isolated regions.
### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
])('test vpc interface endpoint with .cn suffix for %s can be created correctly in China regions',(name: string,given: InterfaceVpcEndpointAwsService)=>{
0 commit comments