Skip to content

Commit 9381880

Browse files
dbartholomaedbartholomae
authored
fix(s3): allow empty string as keyPrefixEquals (#26243)
Closes #26242 . ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 3b9c983 commit 9381880

File tree

11 files changed

+453
-1
lines changed

11 files changed

+453
-1
lines changed

‎packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.bucket.website-routing-rules.js.snapshot/cdk.out

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"version":"32.0.0"}

‎packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.bucket.website-routing-rules.js.snapshot/cdkintegs3bucketDefaultTestDeployAssertB89636B8.assets.json

+19
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
{
2+
"version": "32.0.0",
3+
"files": {
4+
"21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22": {
5+
"source": {
6+
"path": "cdkintegs3bucketDefaultTestDeployAssertB89636B8.template.json",
7+
"packaging": "file"
8+
},
9+
"destinations": {
10+
"current_account-current_region": {
11+
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
12+
"objectKey": "21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22.json",
13+
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
14+
}
15+
}
16+
}
17+
},
18+
"dockerImages": {}
19+
}

‎packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.bucket.website-routing-rules.js.snapshot/cdkintegs3bucketDefaultTestDeployAssertB89636B8.template.json

+36
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
{
2+
"Parameters": {
3+
"BootstrapVersion": {
4+
"Type": "AWS::SSM::Parameter::Value<String>",
5+
"Default": "/cdk-bootstrap/hnb659fds/version",
6+
"Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"
7+
}
8+
},
9+
"Rules": {
10+
"CheckBootstrapVersion": {
11+
"Assertions": [
12+
{
13+
"Assert": {
14+
"Fn::Not": [
15+
{
16+
"Fn::Contains": [
17+
[
18+
"1",
19+
"2",
20+
"3",
21+
"4",
22+
"5"
23+
],
24+
{
25+
"Ref": "BootstrapVersion"
26+
}
27+
]
28+
}
29+
]
30+
},
31+
"AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."
32+
}
33+
]
34+
}
35+
}
36+
}

‎packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.bucket.website-routing-rules.js.snapshot/integ.json

+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{
2+
"version": "32.0.0",
3+
"testCases": {
4+
"cdk-integ-s3-bucket/DefaultTest": {
5+
"stacks": [
6+
"s3-bucket-routing"
7+
],
8+
"assertionStack": "cdk-integ-s3-bucket/DefaultTest/DeployAssert",
9+
"assertionStackName": "cdkintegs3bucketDefaultTestDeployAssertB89636B8"
10+
}
11+
}
12+
}

‎packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.bucket.website-routing-rules.js.snapshot/manifest.json

+111
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,111 @@
1+
{
2+
"version": "32.0.0",
3+
"artifacts": {
4+
"s3-bucket-routing.assets": {
5+
"type": "cdk:asset-manifest",
6+
"properties": {
7+
"file": "s3-bucket-routing.assets.json",
8+
"requiresBootstrapStackVersion": 6,
9+
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version"
10+
}
11+
},
12+
"s3-bucket-routing": {
13+
"type": "aws:cloudformation:stack",
14+
"environment": "aws://unknown-account/unknown-region",
15+
"properties": {
16+
"templateFile": "s3-bucket-routing.template.json",
17+
"validateOnSynth": false,
18+
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-deploy-role-${AWS::AccountId}-${AWS::Region}",
19+
"cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-${AWS::Region}",
20+
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/4c953dadd81493b9ba7f2a1c7b5aea35907c8e0df9be35cd5171c5d4393f5482.json",
21+
"requiresBootstrapStackVersion": 6,
22+
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version",
23+
"additionalDependencies": [
24+
"s3-bucket-routing.assets"
25+
],
26+
"lookupRole": {
27+
"arn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-lookup-role-${AWS::AccountId}-${AWS::Region}",
28+
"requiresBootstrapStackVersion": 8,
29+
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version"
30+
}
31+
},
32+
"dependencies": [
33+
"s3-bucket-routing.assets"
34+
],
35+
"metadata": {
36+
"/s3-bucket-routing/MyBucketWithRoutingRules/Resource": [
37+
{
38+
"type": "aws:cdk:logicalId",
39+
"data": "MyBucketWithRoutingRulesC6E1CAA2"
40+
}
41+
],
42+
"/s3-bucket-routing/BootstrapVersion": [
43+
{
44+
"type": "aws:cdk:logicalId",
45+
"data": "BootstrapVersion"
46+
}
47+
],
48+
"/s3-bucket-routing/CheckBootstrapVersion": [
49+
{
50+
"type": "aws:cdk:logicalId",
51+
"data": "CheckBootstrapVersion"
52+
}
53+
]
54+
},
55+
"displayName": "s3-bucket-routing"
56+
},
57+
"cdkintegs3bucketDefaultTestDeployAssertB89636B8.assets": {
58+
"type": "cdk:asset-manifest",
59+
"properties": {
60+
"file": "cdkintegs3bucketDefaultTestDeployAssertB89636B8.assets.json",
61+
"requiresBootstrapStackVersion": 6,
62+
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version"
63+
}
64+
},
65+
"cdkintegs3bucketDefaultTestDeployAssertB89636B8": {
66+
"type": "aws:cloudformation:stack",
67+
"environment": "aws://unknown-account/unknown-region",
68+
"properties": {
69+
"templateFile": "cdkintegs3bucketDefaultTestDeployAssertB89636B8.template.json",
70+
"validateOnSynth": false,
71+
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-deploy-role-${AWS::AccountId}-${AWS::Region}",
72+
"cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-${AWS::Region}",
73+
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22.json",
74+
"requiresBootstrapStackVersion": 6,
75+
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version",
76+
"additionalDependencies": [
77+
"cdkintegs3bucketDefaultTestDeployAssertB89636B8.assets"
78+
],
79+
"lookupRole": {
80+
"arn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-lookup-role-${AWS::AccountId}-${AWS::Region}",
81+
"requiresBootstrapStackVersion": 8,
82+
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version"
83+
}
84+
},
85+
"dependencies": [
86+
"cdkintegs3bucketDefaultTestDeployAssertB89636B8.assets"
87+
],
88+
"metadata": {
89+
"/cdk-integ-s3-bucket/DefaultTest/DeployAssert/BootstrapVersion": [
90+
{
91+
"type": "aws:cdk:logicalId",
92+
"data": "BootstrapVersion"
93+
}
94+
],
95+
"/cdk-integ-s3-bucket/DefaultTest/DeployAssert/CheckBootstrapVersion": [
96+
{
97+
"type": "aws:cdk:logicalId",
98+
"data": "CheckBootstrapVersion"
99+
}
100+
]
101+
},
102+
"displayName": "cdk-integ-s3-bucket/DefaultTest/DeployAssert"
103+
},
104+
"Tree": {
105+
"type": "cdk:tree",
106+
"properties": {
107+
"file": "tree.json"
108+
}
109+
}
110+
}
111+
}

‎packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.bucket.website-routing-rules.js.snapshot/s3-bucket-routing.assets.json

+19
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
{
2+
"version": "32.0.0",
3+
"files": {
4+
"4c953dadd81493b9ba7f2a1c7b5aea35907c8e0df9be35cd5171c5d4393f5482": {
5+
"source": {
6+
"path": "s3-bucket-routing.template.json",
7+
"packaging": "file"
8+
},
9+
"destinations": {
10+
"current_account-current_region": {
11+
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
12+
"objectKey": "4c953dadd81493b9ba7f2a1c7b5aea35907c8e0df9be35cd5171c5d4393f5482.json",
13+
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
14+
}
15+
}
16+
}
17+
},
18+
"dockerImages": {}
19+
}

‎packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.bucket.website-routing-rules.js.snapshot/s3-bucket-routing.template.json

+60
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
1+
{
2+
"Resources": {
3+
"MyBucketWithRoutingRulesC6E1CAA2": {
4+
"Type": "AWS::S3::Bucket",
5+
"Properties": {
6+
"WebsiteConfiguration": {
7+
"IndexDocument": "index.html",
8+
"RoutingRules": [
9+
{
10+
"RedirectRule": {
11+
"HostName": "example.com",
12+
"Protocol": "https",
13+
"ReplaceKeyWith": "/"
14+
},
15+
"RoutingRuleCondition": {
16+
"KeyPrefixEquals": ""
17+
}
18+
}
19+
]
20+
}
21+
},
22+
"UpdateReplacePolicy": "Delete",
23+
"DeletionPolicy": "Delete"
24+
}
25+
},
26+
"Parameters": {
27+
"BootstrapVersion": {
28+
"Type": "AWS::SSM::Parameter::Value<String>",
29+
"Default": "/cdk-bootstrap/hnb659fds/version",
30+
"Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"
31+
}
32+
},
33+
"Rules": {
34+
"CheckBootstrapVersion": {
35+
"Assertions": [
36+
{
37+
"Assert": {
38+
"Fn::Not": [
39+
{
40+
"Fn::Contains": [
41+
[
42+
"1",
43+
"2",
44+
"3",
45+
"4",
46+
"5"
47+
],
48+
{
49+
"Ref": "BootstrapVersion"
50+
}
51+
]
52+
}
53+
]
54+
},
55+
"AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."
56+
}
57+
]
58+
}
59+
}
60+
}

0 commit comments

Comments
 (0)