Skip to content

Commit 8fcc210

Browse files
authored
chore(route53): migrate existing record set handler (#28053)
This PR moves the delete existing record set handler from aws-cdk-lib to our new centralized location for custom resource handlers in the [@aws-cdk](https://github.com/aws-cdk) package. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 2c21ea0 commit 8fcc210

File tree

11 files changed

+14
-66
lines changed

11 files changed

+14
-66
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.delete-existing-record-set.js.snapshot/asset.482643dcf7106ecdc7f4ff9aefba13d1e5c7265377e6c6b9c77245f2bc55f6ef/index.js

-55
This file was deleted.

packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.delete-existing-record-set.js.snapshot/asset.a4d4a9308995dd99b8a8a3089e4f2087a577a6d3f8a3fc902354155a2b0b00c5/index.js

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.delete-existing-record-set.js.snapshot/cdk-route53-integ-delete-existing-record-set.assets.json

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.delete-existing-record-set.js.snapshot/cdk-route53-integ-delete-existing-record-set.template.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@
151151
"S3Bucket": {
152152
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
153153
},
154-
"S3Key": "482643dcf7106ecdc7f4ff9aefba13d1e5c7265377e6c6b9c77245f2bc55f6ef.zip"
154+
"S3Key": "a4d4a9308995dd99b8a8a3089e4f2087a577a6d3f8a3fc902354155a2b0b00c5.zip"
155155
},
156156
"Timeout": 900,
157157
"MemorySize": 128,

packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.delete-existing-record-set.js.snapshot/manifest.json

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-route53/test/integ.delete-existing-record-set.js.snapshot/tree.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/aws-cdk-lib/aws-route53/test/delete-existing-record-set-handler.test.ts renamed to packages/@aws-cdk/custom-resource-handlers/test/aws-route53/delete-existing-record-set-handler.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { handler } from '../lib/delete-existing-record-set-handler';
1+
import { handler } from '../../lib/aws-route53/delete-existing-record-set-handler';
22

33
const mockListResourceRecordSetsResponse = jest.fn();
44
const mockChangeResourceRecordSetsResponse = jest.fn();

packages/aws-cdk-lib/aws-route53/lib/delete-existing-record-set-handler/.is_custom_resource

Whitespace-only changes.

packages/aws-cdk-lib/aws-route53/lib/record-set.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ export class RecordSet extends Resource implements IRecordSet {
269269
if (props.deleteExisting) {
270270
// Delete existing record before creating the new one
271271
const provider = CustomResourceProvider.getOrCreateProvider(this, DELETE_EXISTING_RECORD_SET_RESOURCE_TYPE, {
272-
codeDirectory: path.join(__dirname, 'delete-existing-record-set-handler'),
272+
codeDirectory: path.join(__dirname, '..', '..', 'custom-resource-handlers', 'dist', 'aws-route53', 'delete-existing-record-set-handler'),
273273
runtime: CustomResourceProviderRuntime.NODEJS_18_X,
274274
policyStatements: [{ // IAM permissions for all providers
275275
Effect: 'Allow',

0 commit comments

Comments
 (0)