Skip to content

Commit 8c926f4

Browse files
committed
updated test cases
1 parent 5d19137 commit 8c926f4

File tree

3 files changed

+34
-9
lines changed

3 files changed

+34
-9
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-docdb/test/integ.cluster-removal-policy-snapshot.js.snapshot/aws-cdk-docdb-removal-policy-snapshot-stack.template.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -542,8 +542,8 @@
542542
"VPCPublicSubnet2DefaultRouteB7481BBA",
543543
"VPCPublicSubnet2RouteTableAssociation5A808732"
544544
],
545-
"UpdateReplacePolicy": "Retain",
546-
"DeletionPolicy": "Retain"
545+
"UpdateReplacePolicy": "Delete",
546+
"DeletionPolicy": "Delete"
547547
}
548548
},
549549
"Parameters": {

packages/@aws-cdk-testing/framework-integ/test/aws-docdb/test/integ.cluster-removal-policy-snapshot.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ class TestStack extends cdk.Stack {
4242
parameterGroup: params,
4343
kmsKey,
4444
removalPolicy: cdk.RemovalPolicy.SNAPSHOT,
45-
instanceRemovalPolicy: cdk.RemovalPolicy.RETAIN, // Remember to cleanup after running this test
4645
enablePerformanceInsights: true,
4746
});
4847

packages/aws-cdk-lib/aws-docdb/test/cluster.test.ts

Lines changed: 32 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1013,13 +1013,26 @@ describe('DatabaseCluster', () => {
10131013
},
10141014
instanceType: ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE2, ec2.InstanceSize.SMALL),
10151015
vpc,
1016-
instanceRemovalPolicy: cdk.RemovalPolicy.DESTROY,
1016+
removalPolicy: cdk.RemovalPolicy.SNAPSHOT,
1017+
instanceRemovalPolicy: cdk.RemovalPolicy.RETAIN,
10171018
});
10181019

10191020
// THEN
1021+
Template.fromStack(stack).hasResource('AWS::DocDB::DBCluster', {
1022+
Properties: {
1023+
DBSubnetGroupName: { Ref: 'DatabaseSubnets56F17B9A' },
1024+
MasterUsername: 'admin',
1025+
MasterUserPassword: 'tooshort',
1026+
VpcSecurityGroupIds: [{ 'Fn::GetAtt': ['DatabaseSecurityGroup5C91FDCB', 'GroupId'] }],
1027+
},
1028+
DeletionPolicy: 'Snapshot',
1029+
UpdateReplacePolicy: 'Snapshot',
1030+
});
1031+
1032+
// Associated instance gets specified policy
10201033
Template.fromStack(stack).hasResource('AWS::DocDB::DBInstance', {
1021-
DeletionPolicy: 'Delete',
1022-
UpdateReplacePolicy: 'Delete',
1034+
DeletionPolicy: 'Retain',
1035+
UpdateReplacePolicy: 'Retain',
10231036
});
10241037
});
10251038

@@ -1037,13 +1050,26 @@ describe('DatabaseCluster', () => {
10371050
},
10381051
instanceType: ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE2, ec2.InstanceSize.SMALL),
10391052
vpc,
1040-
securityGroupRemovalPolicy: cdk.RemovalPolicy.DESTROY,
1053+
removalPolicy: cdk.RemovalPolicy.SNAPSHOT,
1054+
securityGroupRemovalPolicy: cdk.RemovalPolicy.RETAIN,
10411055
});
10421056

10431057
// THEN
1058+
Template.fromStack(stack).hasResource('AWS::DocDB::DBCluster', {
1059+
Properties: {
1060+
DBSubnetGroupName: { Ref: 'DatabaseSubnets56F17B9A' },
1061+
MasterUsername: 'admin',
1062+
MasterUserPassword: 'tooshort',
1063+
VpcSecurityGroupIds: [{ 'Fn::GetAtt': ['DatabaseSecurityGroup5C91FDCB', 'GroupId'] }],
1064+
},
1065+
DeletionPolicy: 'Snapshot',
1066+
UpdateReplacePolicy: 'Snapshot',
1067+
});
1068+
1069+
// Associated security group gets specified policy
10441070
Template.fromStack(stack).hasResource('AWS::EC2::SecurityGroup', {
1045-
DeletionPolicy: 'Delete',
1046-
UpdateReplacePolicy: 'Delete',
1071+
DeletionPolicy: 'Retain',
1072+
UpdateReplacePolicy: 'Retain',
10471073
});
10481074
});
10491075

0 commit comments

Comments
 (0)