Skip to content

Commit 8b35b12

Browse files
authored
chore(core): can't override bootstrapQualifier property (#23235)
On newer versions of typescript you will get an error like `'bootstrapQualifier' is defined as a property in class 'StackSynthesizer', but is overridden here in 'DefaultStackSynthesizer' as an accessor.` Just make the property mutable instead. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Construct Runtime Dependencies: * [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 65eca47 commit 8b35b12

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

packages/@aws-cdk/core/lib/stack-synthesizers/cli-credentials-synthesizer.ts

+3
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,9 @@ export class CliCredentialsStackSynthesizer extends StackSynthesizer {
117117
}
118118
}
119119

120+
/**
121+
* The qualifier used to bootstrap this stack
122+
*/
120123
public get bootstrapQualifier(): string | undefined {
121124
return this.qualifier;
122125
}

packages/@aws-cdk/core/lib/stack-synthesizers/default-synthesizer.ts

+3
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,9 @@ export class DefaultStackSynthesizer extends StackSynthesizer {
324324
}
325325
}
326326

327+
/**
328+
* The qualifier used to bootstrap this stack
329+
*/
327330
public get bootstrapQualifier(): string | undefined {
328331
return this.qualifier;
329332
}

packages/@aws-cdk/core/lib/stack-synthesizers/nested.ts

+3
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ import { IStackSynthesizer, ISynthesisSession } from './types';
1111
* App builder do not need to use this class directly.
1212
*/
1313
export class NestedStackSynthesizer extends StackSynthesizer {
14+
/**
15+
* The qualifier used to bootstrap this stack
16+
*/
1417
public readonly bootstrapQualifier?: string;
1518
constructor(private readonly parentDeployment: IStackSynthesizer) {
1619
super();

packages/@aws-cdk/core/lib/stack-synthesizers/stack-synthesizer.ts

-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ import { IStackSynthesizer, ISynthesisSession } from './types';
1919
* and could not be accessed by external implementors.
2020
*/
2121
export abstract class StackSynthesizer implements IStackSynthesizer {
22-
public readonly bootstrapQualifier?: string;
23-
2422
private _boundStack?: Stack;
2523

2624
/**

0 commit comments

Comments
 (0)