feat(kinesisfirehose): throw ValidationErrors instead of untyped Errors (#33912)

### Issue # (if applicable)

`aws-kinesisfirehose` for #32569

### Description of changes

ValidationErrors everywhere

### Describe any new or updated permissions being added

None

### Description of how you validated changes

Existing tests. Exemptions granted as this is a refactor of existing code.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: Tietew

Diff for: packages/aws-cdk-lib/.eslintrc.js

@@ -57,6 +57,7 @@ const enableNoThrowDefaultErrorIn = [
   'aws-elasticloadbalancingv2',
   'aws-elasticloadbalancingv2-actions',
   'aws-elasticloadbalancingv2-targets',
+  'aws-kinesisfirehose',
   'aws-lambda',
   'aws-logs',
   'aws-rds',

Diff for: packages/aws-cdk-lib/aws-kinesisfirehose/lib/delivery-stream.ts

@@ -277,13 +277,13 @@ export class DeliveryStream extends DeliveryStreamBase {
    */
   static fromDeliveryStreamAttributes(scope: Construct, id: string, attrs: DeliveryStreamAttributes): IDeliveryStream {
     if (!attrs.deliveryStreamName && !attrs.deliveryStreamArn) {
-      throw new Error('Either deliveryStreamName or deliveryStreamArn must be provided in DeliveryStreamAttributes');
+      throw new cdk.ValidationError('Either deliveryStreamName or deliveryStreamArn must be provided in DeliveryStreamAttributes', scope);
     }
     const deliveryStreamName = attrs.deliveryStreamName ??
       cdk.Stack.of(scope).splitArn(attrs.deliveryStreamArn!, cdk.ArnFormat.SLASH_RESOURCE_NAME).resourceName;
 
     if (!deliveryStreamName) {
-      throw new Error(`No delivery stream name found in ARN: '${attrs.deliveryStreamArn}'`);
+      throw new cdk.ValidationError(`No delivery stream name found in ARN: '${attrs.deliveryStreamArn}'`, scope);
     }
     const deliveryStreamArn = attrs.deliveryStreamArn ?? cdk.Stack.of(scope).formatArn({
       service: 'firehose',
@@ -334,7 +334,7 @@ export class DeliveryStream extends DeliveryStreamBase {
       props.source &&
         (props.encryption?.type === StreamEncryptionType.AWS_OWNED || props.encryption?.type === StreamEncryptionType.CUSTOMER_MANAGED)
     ) {
-      throw new Error('Requested server-side encryption but delivery stream source is a Kinesis data stream. Specify server-side encryption on the data stream instead.');
+      throw new cdk.ValidationError('Requested server-side encryption but delivery stream source is a Kinesis data stream. Specify server-side encryption on the data stream instead.', this);
     }
     const encryptionKey = props.encryption?.encryptionKey ?? (props.encryption?.type === StreamEncryptionType.CUSTOMER_MANAGED ? new kms.Key(this, 'Key') : undefined);
     const encryptionConfig = (encryptionKey || (props.encryption?.type === StreamEncryptionType.AWS_OWNED)) ? {

Diff for: packages/aws-cdk-lib/aws-kinesisfirehose/lib/private/helpers.ts

@@ -69,6 +69,7 @@ export function createLoggingOptions(scope: Construct, props: DestinationLogging
 }
 
 export function createBufferingHints(
+  scope: Construct,
   interval?: cdk.Duration,
   size?: cdk.Size,
 ): CfnDeliveryStream.BufferingHintsProperty | undefined {
@@ -78,11 +79,11 @@ export function createBufferingHints(
 
   const intervalInSeconds = interval?.toSeconds() ?? 300;
   if (intervalInSeconds > 900) {
-    throw new Error(`Buffering interval must be less than 900 seconds. Buffering interval provided was ${intervalInSeconds} seconds.`);
+    throw new cdk.ValidationError(`Buffering interval must be less than 900 seconds. Buffering interval provided was ${intervalInSeconds} seconds.`, scope);
   }
   const sizeInMBs = size?.toMebibytes() ?? 5;
   if (sizeInMBs < 1 || sizeInMBs > 128) {
-    throw new Error(`Buffering size must be between 1 and 128 MiBs. Buffering size provided was ${sizeInMBs} MiBs.`);
+    throw new cdk.ValidationError(`Buffering size must be between 1 and 128 MiBs. Buffering size provided was ${sizeInMBs} MiBs.`, scope);
   }
   return { intervalInSeconds, sizeInMBs };
 }
@@ -153,7 +154,7 @@ export function createBackupConfig(scope: Construct, role: iam.IRole, props?: De
       roleArn: role.roleArn,
       prefix: props.dataOutputPrefix,
       errorOutputPrefix: props.errorOutputPrefix,
-      bufferingHints: createBufferingHints(props.bufferingInterval, props.bufferingSize),
+      bufferingHints: createBufferingHints(scope, props.bufferingInterval, props.bufferingSize),
       compressionFormat: props.compression?.value,
       encryptionConfiguration: createEncryptionConfig(role, props.encryptionKey),
       cloudWatchLoggingOptions: loggingOptions,

Diff for: packages/aws-cdk-lib/aws-kinesisfirehose/lib/s3-bucket.ts

@@ -4,6 +4,7 @@ import { DestinationBindOptions, DestinationConfig, IDestination } from './desti
 import * as iam from '../../aws-iam';
 import * as s3 from '../../aws-s3';
 import { createBackupConfig, createBufferingHints, createEncryptionConfig, createLoggingOptions, createProcessingConfig } from './private/helpers';
+import { UnscopedValidationError } from '../../core';
 
 /**
  * Props for defining an S3 destination of an Amazon Data Firehose delivery stream.
@@ -17,7 +18,7 @@ export interface S3BucketProps extends CommonDestinationS3Props, CommonDestinati
 export class S3Bucket implements IDestination {
   constructor(private readonly bucket: s3.IBucket, private readonly props: S3BucketProps = {}) {
     if (this.props.s3Backup?.mode === BackupMode.FAILED) {
-      throw new Error('S3 destinations do not support BackupMode.FAILED');
+      throw new UnscopedValidationError('S3 destinations do not support BackupMode.FAILED');
     }
   }
 
@@ -42,7 +43,7 @@ export class S3Bucket implements IDestination {
         roleArn: role.roleArn,
         s3BackupConfiguration: backupConfig,
         s3BackupMode: this.getS3BackupMode(),
-        bufferingHints: createBufferingHints(this.props.bufferingInterval, this.props.bufferingSize),
+        bufferingHints: createBufferingHints(scope, this.props.bufferingInterval, this.props.bufferingSize),
         bucketArn: this.bucket.bucketArn,
         compressionFormat: this.props.compression?.value,
         encryptionConfiguration: createEncryptionConfig(role, this.props.encryptionKey),