Skip to content

Commit 7d90993

Browse files
mergify[bot]mergify[bot]
authored
chore(release): 1.153.0 (#20005)
See [CHANGELOG](https://github.com/aws/aws-cdk/blob/bump/1.153.0/CHANGELOG.md)
2 parents 9487b39 + c5dcdeb commit 7d90993

File tree

3,897 files changed

+761941
-11033
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

3,897 files changed

+761941
-11033
lines changed

‎.github/PULL_REQUEST_TEMPLATE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
### New Features
1313

1414
* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
15-
* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?
15+
* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?
1616

1717
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

‎.github/workflows/auto-approve.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ jobs:
1212
permissions:
1313
pull-requests: write
1414
steps:
15-
- uses: hmarr/[email protected].0
15+
- uses: hmarr/[email protected].1
1616
with:
1717
github-token: "${{ secrets.GITHUB_TOKEN }}"

‎.github/workflows/close-stale-issues.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
runs-on: ubuntu-latest
1616
name: Stale issue job
1717
steps:
18-
- uses: aws-actions/stale-issue-cleanup@v3
18+
- uses: aws-actions/stale-issue-cleanup@v5
1919
with:
2020
# Setting messages to an empty string will cause the automation to skip
2121
# that category

‎.github/workflows/close-stale-prs.yml

+23
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
on:
2+
schedule:
3+
# Cron format: min hr day month dow
4+
- cron: "0 0 * * *"
5+
jobs:
6+
close-stale-prs:
7+
permissions:
8+
pull-requests: write
9+
runs-on: ubuntu-latest
10+
steps:
11+
- uses: rix0rrr/close-stale-prs@main
12+
with:
13+
# Required
14+
github-token: ${{ secrets.GITHUB_TOKEN }}
15+
stale-days: 21
16+
response-days: 7
17+
18+
# Optional
19+
important-checks-regex: AutoBuildProject89A8053A
20+
warn-message: This PR has been in the STATE state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.
21+
close-message: This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.
22+
skip-labels: contribution/core
23+
close-label: closed-for-staleness

‎.github/workflows/issue-reprioritization.yml

+22
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
name: issue-reprioritization
2+
on:
3+
schedule:
4+
- cron: "0 0 * * 0"
5+
6+
jobs:
7+
issue-reprioritization:
8+
permissions:
9+
issues: write
10+
runs-on: ubuntu-latest
11+
steps:
12+
- uses: kaizen3031593/issue-reprioritization-manager@main
13+
id: reprioritization-manager
14+
with:
15+
github-token: ${{ secrets.GITHUB_TOKEN }}
16+
original-label: p2
17+
new-label: p1
18+
reprioritization-threshold: 20
19+
- uses: kaizen3031593/pr-triage-manager@main
20+
with:
21+
github-token: ${{ secrets.GITHUB_TOKEN }}
22+
on-pulls: ${{ steps.reprioritization-manager.outputs.linked-pulls }}

‎.github/workflows/yarn-upgrade.yml

+8-4
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ jobs:
4040
npm -g install lerna npm-check-updates@^9.0.0
4141
- name: Build CLI
4242
run: cd packages/aws-cdk && ../../scripts/buildup
43+
- name: Build Integ Runner
44+
run: cd packages/@aws-cdk/integ-runner && ../../../scripts/buildup
4345
- name: List Mono-Repo Packages
4446
id: list-packages
4547
# These need to be ignored from the `ncu` runs!
@@ -63,16 +65,18 @@ jobs:
6365
lerna exec --parallel ncu -- --upgrade --filter=@types/node,@types/fs-extra --target=minor
6466
lerna exec --parallel ncu -- --upgrade --filter=typescript --target=patch
6567
lerna exec --parallel ncu -- --upgrade --reject='@types/node,@types/fs-extra,constructs,typescript,aws-sdk,aws-sdk-mock,${{ steps.list-packages.outputs.list }}' --target=minor
66-
68+
6769
# This will ensure the current lockfile is up-to-date with the dependency specifications (necessary for "yarn update" to run)
6870
- name: Run "yarn install"
6971
run: yarn install
7072

7173
- name: Run "yarn upgrade"
7274
run: yarn upgrade
73-
75+
7476
- name: Regenerate CLI attributions
7577
run: cd packages/aws-cdk && yarn pkglint
78+
- name: Regenerate Integ Runner attributions
79+
run: cd packages/@aws-cdk/integ-runner && yarn pkglint
7680

7781
# Next, create and upload the changes as a patch file. This will later be downloaded to create a pull request
7882
# Creating a pull request requires write permissions and it's best to keep write privileges isolated.
@@ -81,7 +85,7 @@ jobs:
8185
git add .
8286
git diff --patch --staged > ${{ runner.temp }}/upgrade.patch
8387
- name: Upload Patch
84-
uses: actions/upload-artifact@v2
88+
uses: actions/upload-artifact@v3
8589
with:
8690
name: upgrade.patch
8791
path: ${{ runner.temp }}/upgrade.patch
@@ -98,7 +102,7 @@ jobs:
98102
uses: actions/checkout@v3
99103

100104
- name: Download patch
101-
uses: actions/download-artifact@v2
105+
uses: actions/download-artifact@v3
102106
with:
103107
name: upgrade.patch
104108
path: ${{ runner.temp }}

‎CHANGELOG.md

+53
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,59 @@
22

33
All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
44

5+
## [1.153.0](https://github.com/aws/aws-cdk/compare/v1.152.0...v1.153.0) (2022-04-21)
6+
7+
8+
### Features
9+
10+
* **apigatewayv2:** set throttling on stages ([#19776](https://github.com/aws/aws-cdk/issues/19776)) ([3cabd10](https://github.com/aws/aws-cdk/commit/3cabd105288789c03d1a8d508637b2d7f46407a4)), closes [#19626](https://github.com/aws/aws-cdk/issues/19626)
11+
* **autoscaling:** Auto Scaling Group with Launch Template ([#19066](https://github.com/aws/aws-cdk/issues/19066)) ([1581af0](https://github.com/aws/aws-cdk/commit/1581af0e91cd68ace2c76c236be811a4e48bffe6)), closes [#6734](https://github.com/aws/aws-cdk/issues/6734)
12+
* **aws-ecr:** make it easy to reference image tag or digest, use everywhere ([#19799](https://github.com/aws/aws-cdk/issues/19799)) ([380774e](https://github.com/aws/aws-cdk/commit/380774edd5f8c42294651ead3541eebcf029251c)), closes [#13299](https://github.com/aws/aws-cdk/issues/13299) [#15333](https://github.com/aws/aws-cdk/issues/15333)
13+
* **cfnspec:** cloudformation spec v66.0.0 ([#19812](https://github.com/aws/aws-cdk/issues/19812)) ([43735fd](https://github.com/aws/aws-cdk/commit/43735fd85cff3d5f9cdf4e6c9f62ffe4c93a72b4)), closes [#19798](https://github.com/aws/aws-cdk/issues/19798)
14+
* **cfnspec:** cloudformation spec v66.1.0 ([#19929](https://github.com/aws/aws-cdk/issues/19929)) ([8c8b6b6](https://github.com/aws/aws-cdk/commit/8c8b6b68b98e090580357172c247267ce92f2668))
15+
* **cli:** glob-style key matching to context --reset ([#19840](https://github.com/aws/aws-cdk/issues/19840)) ([edb4119](https://github.com/aws/aws-cdk/commit/edb411925cf84ebe38e5a45acdec20f339087ea6)), closes [#19797](https://github.com/aws/aws-cdk/issues/19797)
16+
* **codebuild:** add ability to customize build status reporting for third-party Git sources ([#19408](https://github.com/aws/aws-cdk/issues/19408)) ([423d72f](https://github.com/aws/aws-cdk/commit/423d72f79b979d6f5f8ba70df05b7e1580d6a349))
17+
* **codepipeline:** allow to disable stage transition ([#19911](https://github.com/aws/aws-cdk/issues/19911)) ([ac9901a](https://github.com/aws/aws-cdk/commit/ac9901ada20e0bcadcae0e6f59e5c58220328714)), closes [#1649](https://github.com/aws/aws-cdk/issues/1649)
18+
* **integ-runner:** add missing features from the integ manifest ([#19969](https://github.com/aws/aws-cdk/issues/19969)) ([2ca5050](https://github.com/aws/aws-cdk/commit/2ca5050865f94e033fda850961439d8fcb01f468))
19+
* **integ-runner:** integ-runner enhancements ([#19865](https://github.com/aws/aws-cdk/issues/19865)) ([697fdbe](https://github.com/aws/aws-cdk/commit/697fdbe71642c93492c38e834e654ed736a9edb4))
20+
* **integ-runner:** test update path when running tests ([#19915](https://github.com/aws/aws-cdk/issues/19915)) ([d0ace8f](https://github.com/aws/aws-cdk/commit/d0ace8f2db53d56cdb670979c7c173ee17b6bcd8))
21+
* **integ-tests:** Add `IntegTestCase` ([#19829](https://github.com/aws/aws-cdk/issues/19829)) ([ad249c9](https://github.com/aws/aws-cdk/commit/ad249c9943c2d602b2b077435935731f723db715))
22+
* **iotevents:** support comparison operators ([#19329](https://github.com/aws/aws-cdk/issues/19329)) ([95cb3f3](https://github.com/aws/aws-cdk/commit/95cb3f3c7a4c98ebf4a4818af2f4e725fc16aa29))
23+
* **lambda:** function URLs ([#19817](https://github.com/aws/aws-cdk/issues/19817)) ([4fd515a](https://github.com/aws/aws-cdk/commit/4fd515a3a1de87977ad71329bb7cecb0527558f4)), closes [#19798](https://github.com/aws/aws-cdk/issues/19798)
24+
* **logs:** add QueryDefinition L2 Construct ([#18655](https://github.com/aws/aws-cdk/issues/18655)) ([fcf981b](https://github.com/aws/aws-cdk/commit/fcf981b31c12f0366e49e15d5aa67d412e84caf0))
25+
* **route53:** fromPublicHostedZoneAttributes method with zoneName ([#19771](https://github.com/aws/aws-cdk/issues/19771)) ([7867dc4](https://github.com/aws/aws-cdk/commit/7867dc499af50edad11c9263c37cb71e72193c04)), closes [#18700](https://github.com/aws/aws-cdk/issues/18700)
26+
* **s3-deployment:** ephemeral storage size property for bucket deployment ([#19958](https://github.com/aws/aws-cdk/issues/19958)) ([3ce40b4](https://github.com/aws/aws-cdk/commit/3ce40b4455215b066833fa0ebe0e0a99a2928573)), closes [#19947](https://github.com/aws/aws-cdk/issues/19947)
27+
* check for accidental exposure of secrets ([#19543](https://github.com/aws/aws-cdk/issues/19543)) ([789e8d2](https://github.com/aws/aws-cdk/commit/789e8d2aaa0aefb6d17e4ebc0d56c17e9999add0))
28+
29+
30+
### Bug Fixes
31+
32+
* **autoscaling:** update validation on maxInstanceLifetime ([#19584](https://github.com/aws/aws-cdk/issues/19584)) ([d115b47](https://github.com/aws/aws-cdk/commit/d115b476688eb39a935074490435f855f7fee9c0))
33+
* **aws-cloudfront:** Add sslSupportMethod ([#19737](https://github.com/aws/aws-cdk/issues/19737)) ([c5a9679](https://github.com/aws/aws-cdk/commit/c5a96793818f57141efc78ab60f13b48a3b1e460)), closes [#19476](https://github.com/aws/aws-cdk/issues/19476)
34+
* **aws-ecr-assets:** correct file existence validation in tests ([#19945](https://github.com/aws/aws-cdk/issues/19945)) ([d4c13c0](https://github.com/aws/aws-cdk/commit/d4c13c01c2d2a910a09db7c6fdfc67f410d6b195)), closes [40aws-cdk/aws-ecr-assets/test/image-asset.test.ts#L387](https://github.com/40aws-cdk/aws-ecr-assets/test/image-asset.test.ts/issues/L387) [#19944](https://github.com/aws/aws-cdk/issues/19944)
35+
* **cfn-diff:** allow resources to change types ([#19891](https://github.com/aws/aws-cdk/issues/19891)) ([4f3a340](https://github.com/aws/aws-cdk/commit/4f3a340ab8794ce793b903042a6ba9470bec8955)), closes [#13921](https://github.com/aws/aws-cdk/issues/13921)
36+
* **cfn-include:** detect a resource cycle in the included template ([#19871](https://github.com/aws/aws-cdk/issues/19871)) ([2c2bc0b](https://github.com/aws/aws-cdk/commit/2c2bc0b4ba2be87706a87c141f35f32fbe1ea615)), closes [#16654](https://github.com/aws/aws-cdk/issues/16654)
37+
* **cfnspec:** aws-sam deployment preferences hooks ([#19732](https://github.com/aws/aws-cdk/issues/19732)) ([a205734](https://github.com/aws/aws-cdk/commit/a205734f609202c168119dddf1fdc30080f18744))
38+
* **cfnSpec:** wrong type for SAM API properties GatewayResponses and Models ([#19885](https://github.com/aws/aws-cdk/issues/19885)) ([b214ede](https://github.com/aws/aws-cdk/commit/b214ede1bd264afc1de7f34541bfc4220fa507bc)), closes [#19870](https://github.com/aws/aws-cdk/issues/19870)
39+
* **cli:** hangs on retrieving notices ([#19967](https://github.com/aws/aws-cdk/issues/19967)) ([daeeafa](https://github.com/aws/aws-cdk/commit/daeeafa5855d3bbb5b5070f10fd7cba52d035112)), closes [#19542](https://github.com/aws/aws-cdk/issues/19542)
40+
* **cli:** stack monitor prints over error messages ([#19859](https://github.com/aws/aws-cdk/issues/19859)) ([42e5d08](https://github.com/aws/aws-cdk/commit/42e5d08be2b505b4cf6ca818844c02b95bc43e43)), closes [#19742](https://github.com/aws/aws-cdk/issues/19742)
41+
* **cloudwatch:** MathExpression `id` contract is not clear ([#19825](https://github.com/aws/aws-cdk/issues/19825)) ([5472b11](https://github.com/aws/aws-cdk/commit/5472b11ab1d10514dd5f67dfaf5e21eba979d572)), closes [#13942](https://github.com/aws/aws-cdk/issues/13942) [#17126](https://github.com/aws/aws-cdk/issues/17126)
42+
* **core:** exportValue does not work on number attributes ([#19818](https://github.com/aws/aws-cdk/issues/19818)) ([12459ca](https://github.com/aws/aws-cdk/commit/12459ca368012a81bfc11c023a100764cf8fd0ed)), closes [#19537](https://github.com/aws/aws-cdk/issues/19537)
43+
* **docdb:** make most attributes of DatabaseClusterAttributes optional ([#19625](https://github.com/aws/aws-cdk/issues/19625)) ([5f6d20c](https://github.com/aws/aws-cdk/commit/5f6d20c2a881ffd9decaa8afe3d35dd677b601f1)), closes [#14492](https://github.com/aws/aws-cdk/issues/14492)
44+
* **ecr:** scanOnPush not supported in certain regions ([#19940](https://github.com/aws/aws-cdk/issues/19940)) ([2ff3143](https://github.com/aws/aws-cdk/commit/2ff3143ad47d4dcf963fdb5d0e333a3a86ef8a2e)), closes [#19918](https://github.com/aws/aws-cdk/issues/19918)
45+
* **ecs:** get rid of EFS casing warnings ([#19681](https://github.com/aws/aws-cdk/issues/19681)) ([eafc11a](https://github.com/aws/aws-cdk/commit/eafc11afbd6a09451afbecd8110c1e0a1a9088a4)), closes [#15025](https://github.com/aws/aws-cdk/issues/15025)
46+
* **eks:** malformed command when installing helm chart from OCI artifact ([#19778](https://github.com/aws/aws-cdk/issues/19778)) ([f8babb8](https://github.com/aws/aws-cdk/commit/f8babb8f0f88fec6216bcb5de95ac4ec57be39db)), closes [/github.com/aws/aws-cdk/pull/18547#issuecomment-1088737549](https://github.com/aws//github.com/aws/aws-cdk/pull/18547/issues/issuecomment-1088737549)
47+
* **iam:** role/group/user's path not included in ARN ([#13258](https://github.com/aws/aws-cdk/issues/13258)) ([ef2b480](https://github.com/aws/aws-cdk/commit/ef2b480699f687aace64481ece654842461a9f13)), closes [#13156](https://github.com/aws/aws-cdk/issues/13156)
48+
* **integ-runner:** enable all feature flags by default ([#19955](https://github.com/aws/aws-cdk/issues/19955)) ([ca3920d](https://github.com/aws/aws-cdk/commit/ca3920dbd588ebd9c68f17bfbf420713cf42790a))
49+
* **lambda-event-sources:** unsupported property `onFailure` for KafkaEventSources ([#19995](https://github.com/aws/aws-cdk/issues/19995)) ([383171b](https://github.com/aws/aws-cdk/commit/383171b54873705a01b7f113a7c6b5c98be2117b)), closes [#19917](https://github.com/aws/aws-cdk/issues/19917)
50+
* **rds:** MySQL 8.0 uses wrong Parameter for S3 export ([#19775](https://github.com/aws/aws-cdk/issues/19775)) ([5a895a3](https://github.com/aws/aws-cdk/commit/5a895a308ef2b6e66a330038c7ae35ea95a0fba4)), closes [#19735](https://github.com/aws/aws-cdk/issues/19735)
51+
* **stepfunctions:** incorrect default documentation for integrationPattern ([#19936](https://github.com/aws/aws-cdk/issues/19936)) ([4cb3b2b](https://github.com/aws/aws-cdk/commit/4cb3b2bdb959ae398ffe2f8a5a927280f5d63306)), closes [#19815](https://github.com/aws/aws-cdk/issues/19815)
52+
53+
54+
### Reverts
55+
56+
* "feat(cli): glob-style key matching to context --reset ([#19840](https://github.com/aws/aws-cdk/issues/19840))" ([#19888](https://github.com/aws/aws-cdk/issues/19888)) ([89ec597](https://github.com/aws/aws-cdk/commit/89ec5972e855695fee61628440e61df79c12fdc5))
57+
558
## [1.152.0](https://github.com/aws/aws-cdk/compare/v1.151.0...v1.152.0) (2022-04-06)
659

760

‎CONTRIBUTING.md

+37-8
Original file line numberDiff line numberDiff line change
@@ -172,23 +172,49 @@ eval $(gp env -e)
172172

173173
## Pull Requests
174174

175+
Below is a flow chart that describes how your PR may be treated by repository maintainers:
176+
177+
```mermaid
178+
graph TD
179+
A[Incoming PR] -->B[Is an issue attached?]
180+
B -->|Yes - labels copied from issue| C[Is it labeled P1?]
181+
B -->|No - auto-labeled as P2| D["Is the effort small?"]
182+
C -->|Yes - P1| E[Is the PR build succeeding?]
183+
C -->|No - it is P2| D
184+
D -->|Yes| E
185+
D -->|No| F[Can you break down the PR into smaller chunks?]
186+
F --->|Yes| I[Please do. This will help get traction on your PR.]
187+
F -->|No| J[Try to garner community support on the issue you are <br/> trying to solve. With 20 +1s, the issue will be relabeled as P1.]
188+
E --->|Yes| G[We will review your PR as soon as we can]
189+
E -->|No| H[If the build is failing for more than 4 weeks <br/> without any work on it, we will close the PR.]
190+
```
191+
192+
Note that, if we do not have time to review your PR, it is not the end of the road. We are asking
193+
for more community support on the attached issue before we focus our attention there. Any `P2` issue
194+
with 20 or more +1s will be automatically upgraded from `P2`to `P1`.
195+
175196
### Step 1: Find something to work on
176197

177-
If you want to contribute a specific feature or fix you have in mind, look at active [pull
178-
requests](https://github.com/aws/aws-cdk/pulls) to see if someone else is already working on it. If not, you can start
179-
contributing your changes.
198+
If you want to contribute a specific feature or fix you have in mind, look to see if an issue
199+
already exists in our [backlog](https://github.com/aws/aws-cdk/issues). If not, please contribute
200+
a feature request or bug report prior to contributing the PR. We will triage this issue promptly,
201+
and the priority of the issue (`P1` or `P2`) will give indication of how much attention your PR
202+
may get.
203+
204+
It's not required to submit an issue first, but PRs that come in without attached issues will be
205+
automatically labeled as `P2`.
180206

181207
On the other hand, if you are here looking for an issue to work on, explore our [backlog of
182-
issues](https://github.com/aws/aws-cdk/issues) and find something that piques your interest. We have labeled all of our
183-
issues for easy searching.
184-
If you are looking for your first contribution, the ['good first issue'
185-
label](https://github.com/aws/aws-cdk/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) will be of help.
208+
issues](https://github.com/aws/aws-cdk/issues) and find something that piques your interest.
209+
We have labeled all of our issues for easy searching. If you are looking for your first contribution,
210+
the ['good first issue' label](https://github.com/aws/aws-cdk/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
211+
will be of help.
186212

187213
It's a good idea to keep the priority of issues in mind when deciding what to
188214
work on. If we have labelled an issue as `P2`, it means it's something we won't
189215
get to soon, and we're waiting on more feedback from the community (in the form
190216
of +1s and comments) to give it a higher priority. A PR for a `P2` issue may
191-
take us some time to review, especially if it involves a complex
217+
be closed by a maintainer, especially if it involves a complex
192218
implementation. `P1` issues impact a significant number of customers, so we are
193219
much more likely to give a PR for those issues prompt attention.
194220

@@ -325,6 +351,9 @@ $ yarn watch & # runs in the background
325351

326352
* Once the pull request is submitted, a reviewer will be assigned by the maintainers.
327353

354+
* If the PR build is failing, update the PR with fixes until the build succeeds. You may have trouble getting attention
355+
from maintainers if your build is failing, and after 4 weeks of staleness, your PR will be automatically closed.
356+
328357
* Discuss review comments and iterate until you get at least one "Approve". When iterating, push new commits to the
329358
same branch. Usually all these are going to be squashed when you merge to master. The commit messages should be hints
330359
for you when you finalize your merge commit message.

0 commit comments

Comments
 (0)