Skip to content

Commit 7a30f5d

Browse files
authored
fix(eks): helm uninstall in custom resource handler does not respect Wait (#28830)
I have a stack that installs and uninstalls helm charts, where the underlying resources use [Kubernetes Finalizers](https://kubernetes.io/docs/concepts/overview/working-with-objects/finalizers/). CDK's helm construct currently ignores `--wait`, which means that any object finalization in those helm charts is not respected in my dependency ordering. ## Compatibility I could see some debate around whether or not this is a breaking change. I'm currently viewing it as a bug fix. I'm a bit cautious about how valuable it would be to gate this behavior compared to the additional complexity. ## Testing Tested on a local fork and it worked like a charm Closes #28831 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 95d187e commit 7a30f5d

File tree

1 file changed

+1
-1
lines changed
  • packages/@aws-cdk/custom-resource-handlers/lib/aws-eks/kubectl-handler/helm

1 file changed

+1
-1
lines changed

packages/@aws-cdk/custom-resource-handlers/lib/aws-eks/kubectl-handler/helm/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def helm_handler(event, context):
9393
helm('upgrade', release, chart, repository, values_file, namespace, version, wait, timeout, create_namespace)
9494
elif request_type == "Delete":
9595
try:
96-
helm('uninstall', release, namespace=namespace, timeout=timeout)
96+
helm('uninstall', release, namespace=namespace, wait=wait, timeout=timeout)
9797
except Exception as e:
9898
logger.info("delete error: %s" % e)
9999

0 commit comments

Comments
 (0)