Skip to content

Commit 787f38a

Browse files
ahmetsoykanahmetsoykan
authored
fix(kinesis): remove StreamModeDetails in template when not specified (#24994)
> optional field of StreamModeDetails removed in the template, when it hasn't set by the construct. Closes #21829. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent d9468c5 commit 787f38a

File tree

70 files changed

+1068
-396
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+1068
-396
lines changed

‎packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.dynamodb.kinesis-stream.js.snapshot/aws-cdk-dynamodb-kinesis-stream.assets.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
{
2-
"version": "20.0.0",
2+
"version": "31.0.0",
33
"files": {
4-
"96ed71a745135c6cdc305de7c81c1a68f705200d6a27acf0d1f9828e39c3ec6a": {
4+
"5af7ba12267a159dc170dcfafe00ee90f79f94f96c245bfe38593f53d0a41052": {
55
"source": {
66
"path": "aws-cdk-dynamodb-kinesis-stream.template.json",
77
"packaging": "file"
88
},
99
"destinations": {
1010
"current_account-current_region": {
1111
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
12-
"objectKey": "96ed71a745135c6cdc305de7c81c1a68f705200d6a27acf0d1f9828e39c3ec6a.json",
12+
"objectKey": "5af7ba12267a159dc170dcfafe00ee90f79f94f96c245bfe38593f53d0a41052.json",
1313
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
1414
}
1515
}

‎packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.dynamodb.kinesis-stream.js.snapshot/aws-cdk-dynamodb-kinesis-stream.template.json

-3
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616
"KeyId": "alias/aws/kinesis"
1717
}
1818
]
19-
},
20-
"StreamModeDetails": {
21-
"StreamMode": "PROVISIONED"
2219
}
2320
}
2421
},

‎packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.dynamodb.kinesis-stream.js.snapshot/cdk.out

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"version":"20.0.0"}
1+
{"version":"31.0.0"}

‎packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.dynamodb.kinesis-stream.js.snapshot/integ.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "20.0.0",
2+
"version": "31.0.0",
33
"testCases": {
44
"integ.dynamodb.kinesis-stream": {
55
"stacks": [

‎packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.dynamodb.kinesis-stream.js.snapshot/manifest.json

+8-8
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
{
2-
"version": "20.0.0",
2+
"version": "31.0.0",
33
"artifacts": {
4-
"Tree": {
5-
"type": "cdk:tree",
6-
"properties": {
7-
"file": "tree.json"
8-
}
9-
},
104
"aws-cdk-dynamodb-kinesis-stream.assets": {
115
"type": "cdk:asset-manifest",
126
"properties": {
@@ -23,7 +17,7 @@
2317
"validateOnSynth": false,
2418
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-deploy-role-${AWS::AccountId}-${AWS::Region}",
2519
"cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-${AWS::Region}",
26-
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/96ed71a745135c6cdc305de7c81c1a68f705200d6a27acf0d1f9828e39c3ec6a.json",
20+
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/5af7ba12267a159dc170dcfafe00ee90f79f94f96c245bfe38593f53d0a41052.json",
2721
"requiresBootstrapStackVersion": 6,
2822
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version",
2923
"additionalDependencies": [
@@ -71,6 +65,12 @@
7165
]
7266
},
7367
"displayName": "aws-cdk-dynamodb-kinesis-stream"
68+
},
69+
"Tree": {
70+
"type": "cdk:tree",
71+
"properties": {
72+
"file": "tree.json"
73+
}
7474
}
7575
}
7676
}

‎packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.dynamodb.kinesis-stream.js.snapshot/tree.json

+35-22
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,6 @@
44
"id": "App",
55
"path": "",
66
"children": {
7-
"Tree": {
8-
"id": "Tree",
9-
"path": "Tree",
10-
"constructInfo": {
11-
"fqn": "constructs.Construct",
12-
"version": "10.1.85"
13-
}
14-
},
157
"aws-cdk-dynamodb-kinesis-stream": {
168
"id": "aws-cdk-dynamodb-kinesis-stream",
179
"path": "aws-cdk-dynamodb-kinesis-stream",
@@ -39,29 +31,26 @@
3931
"KeyId": "alias/aws/kinesis"
4032
}
4133
]
42-
},
43-
"streamModeDetails": {
44-
"streamMode": "PROVISIONED"
4534
}
4635
}
4736
},
4837
"constructInfo": {
49-
"fqn": "@aws-cdk/aws-kinesis.CfnStream",
38+
"fqn": "aws-cdk-lib.aws_kinesis.CfnStream",
5039
"version": "0.0.0"
5140
}
5241
}
5342
},
5443
"constructInfo": {
55-
"fqn": "@aws-cdk/aws-kinesis.Stream",
44+
"fqn": "aws-cdk-lib.aws_kinesis.Stream",
5645
"version": "0.0.0"
5746
}
5847
},
5948
"AwsCdkKinesisEncryptedStreamsUnsupportedRegions": {
6049
"id": "AwsCdkKinesisEncryptedStreamsUnsupportedRegions",
6150
"path": "aws-cdk-dynamodb-kinesis-stream/AwsCdkKinesisEncryptedStreamsUnsupportedRegions",
6251
"constructInfo": {
63-
"fqn": "constructs.Construct",
64-
"version": "10.1.85"
52+
"fqn": "aws-cdk-lib.CfnCondition",
53+
"version": "0.0.0"
6554
}
6655
},
6756
"Table": {
@@ -101,34 +90,58 @@
10190
}
10291
},
10392
"constructInfo": {
104-
"fqn": "@aws-cdk/aws-dynamodb.CfnTable",
93+
"fqn": "aws-cdk-lib.aws_dynamodb.CfnTable",
10594
"version": "0.0.0"
10695
}
10796
},
10897
"ScalingRole": {
10998
"id": "ScalingRole",
11099
"path": "aws-cdk-dynamodb-kinesis-stream/Table/ScalingRole",
111100
"constructInfo": {
112-
"fqn": "constructs.Construct",
113-
"version": "10.1.85"
101+
"fqn": "aws-cdk-lib.Resource",
102+
"version": "0.0.0"
114103
}
115104
}
116105
},
117106
"constructInfo": {
118-
"fqn": "@aws-cdk/aws-dynamodb.Table",
107+
"fqn": "aws-cdk-lib.aws_dynamodb.Table",
108+
"version": "0.0.0"
109+
}
110+
},
111+
"BootstrapVersion": {
112+
"id": "BootstrapVersion",
113+
"path": "aws-cdk-dynamodb-kinesis-stream/BootstrapVersion",
114+
"constructInfo": {
115+
"fqn": "aws-cdk-lib.CfnParameter",
116+
"version": "0.0.0"
117+
}
118+
},
119+
"CheckBootstrapVersion": {
120+
"id": "CheckBootstrapVersion",
121+
"path": "aws-cdk-dynamodb-kinesis-stream/CheckBootstrapVersion",
122+
"constructInfo": {
123+
"fqn": "aws-cdk-lib.CfnRule",
119124
"version": "0.0.0"
120125
}
121126
}
122127
},
128+
"constructInfo": {
129+
"fqn": "aws-cdk-lib.Stack",
130+
"version": "0.0.0"
131+
}
132+
},
133+
"Tree": {
134+
"id": "Tree",
135+
"path": "Tree",
123136
"constructInfo": {
124137
"fqn": "constructs.Construct",
125-
"version": "10.1.85"
138+
"version": "10.1.270"
126139
}
127140
}
128141
},
129142
"constructInfo": {
130-
"fqn": "constructs.Construct",
131-
"version": "10.1.85"
143+
"fqn": "aws-cdk-lib.App",
144+
"version": "0.0.0"
132145
}
133146
}
134147
}

‎packages/@aws-cdk-testing/framework-integ/test/aws-events-targets/test/kinesis/integ.kinesis-stream.js.snapshot/aws-cdk-kinesis-event-target.assets.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
{
2-
"version": "20.0.0",
2+
"version": "31.0.0",
33
"files": {
4-
"9c3c35264f83a7dd2a6f065a425f3ec72b52a57950b28c17accccb128d213615": {
4+
"48fa462be9d7ff000bc7bc73c88ccd663ed424829ffb9f081daac83a046c316e": {
55
"source": {
66
"path": "aws-cdk-kinesis-event-target.template.json",
77
"packaging": "file"
88
},
99
"destinations": {
1010
"current_account-current_region": {
1111
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
12-
"objectKey": "9c3c35264f83a7dd2a6f065a425f3ec72b52a57950b28c17accccb128d213615.json",
12+
"objectKey": "48fa462be9d7ff000bc7bc73c88ccd663ed424829ffb9f081daac83a046c316e.json",
1313
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
1414
}
1515
}

‎packages/@aws-cdk-testing/framework-integ/test/aws-events-targets/test/kinesis/integ.kinesis-stream.js.snapshot/aws-cdk-kinesis-event-target.template.json

-3
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616
"KeyId": "alias/aws/kinesis"
1717
}
1818
]
19-
},
20-
"StreamModeDetails": {
21-
"StreamMode": "PROVISIONED"
2219
}
2320
}
2421
},

‎packages/@aws-cdk-testing/framework-integ/test/aws-events-targets/test/kinesis/integ.kinesis-stream.js.snapshot/cdk.out

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"version":"20.0.0"}
1+
{"version":"31.0.0"}

‎packages/@aws-cdk-testing/framework-integ/test/aws-events-targets/test/kinesis/integ.kinesis-stream.js.snapshot/integ.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "20.0.0",
2+
"version": "31.0.0",
33
"testCases": {
44
"integ.kinesis-stream": {
55
"stacks": [

‎packages/@aws-cdk-testing/framework-integ/test/aws-events-targets/test/kinesis/integ.kinesis-stream.js.snapshot/manifest.json

+8-8
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
{
2-
"version": "20.0.0",
2+
"version": "31.0.0",
33
"artifacts": {
4-
"Tree": {
5-
"type": "cdk:tree",
6-
"properties": {
7-
"file": "tree.json"
8-
}
9-
},
104
"aws-cdk-kinesis-event-target.assets": {
115
"type": "cdk:asset-manifest",
126
"properties": {
@@ -23,7 +17,7 @@
2317
"validateOnSynth": false,
2418
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-deploy-role-${AWS::AccountId}-${AWS::Region}",
2519
"cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-${AWS::Region}",
26-
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/9c3c35264f83a7dd2a6f065a425f3ec72b52a57950b28c17accccb128d213615.json",
20+
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/48fa462be9d7ff000bc7bc73c88ccd663ed424829ffb9f081daac83a046c316e.json",
2721
"requiresBootstrapStackVersion": 6,
2822
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version",
2923
"additionalDependencies": [
@@ -83,6 +77,12 @@
8377
]
8478
},
8579
"displayName": "aws-cdk-kinesis-event-target"
80+
},
81+
"Tree": {
82+
"type": "cdk:tree",
83+
"properties": {
84+
"file": "tree.json"
85+
}
8686
}
8787
}
8888
}

0 commit comments

Comments
 (0)