Skip to content

Commit 704ff0b

Browse files
authored
chore(eslint): lint against padded lines after class declarations (#33071)
Linter rule to ensure that we don't have padded lines within our class declarations. This helps standardize a pattern that we review for already. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 066cd4f commit 704ff0b

File tree

283 files changed

+3
-379
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

283 files changed

+3
-379
lines changed

packages/@aws-cdk-testing/cli-integ/lib/aws.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ interface ClientConfig {
2929
}
3030

3131
export class AwsClients {
32-
3332
public static async forRegion(region: string, output: NodeJS.WritableStream) {
3433
return new AwsClients(region, output);
3534
}

packages/@aws-cdk-testing/cli-integ/lib/with-cli-lib.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,5 @@ __EOS__`], {
135135
},
136136
});
137137
}
138-
139138
}
140139

packages/@aws-cdk-testing/framework-integ/test/aws-appsync/test/integ.graphql-grant-imported-api.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { IntegTest } from '@aws-cdk/integ-tests-alpha';
1212
import { ServicePrincipal, Role } from 'aws-cdk-lib/aws-iam';
1313

1414
class OriginalStack extends Stack {
15-
1615
public readonly apiId: string;
1716

1817
constructor(scope: App, id: string) {

packages/@aws-cdk-testing/framework-integ/test/aws-cloudwatch-actions/test/integ.lambda-alarm-action.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import * as cloudwatchActions from 'aws-cdk-lib/aws-cloudwatch-actions';
77
import { LAMBDA_PERMISSION_LOGICAL_ID_FOR_LAMBDA_ACTION } from 'aws-cdk-lib/cx-api';
88

99
class LambdaAlarmActionIntegrationTestStack extends Stack {
10-
1110
constructor(scope: App, id: string, props?: StackProps) {
1211
super(scope, id, props);
1312

packages/@aws-cdk-testing/framework-integ/test/aws-cloudwatch-actions/test/integ.ssm-incident-alarm-action.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import * as integ from '@aws-cdk/integ-tests-alpha';
77
import * as cloudwatchActions from 'aws-cdk-lib/aws-cloudwatch-actions';
88

99
class SsmIncidentAlarmActionIntegrationTestStack extends Stack {
10-
1110
constructor(scope: App, id: string, props?: StackProps) {
1211
super(scope, id, props);
1312

packages/@aws-cdk-testing/framework-integ/test/aws-cloudwatch/test/integ.alarm-with-label.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { IntegTest } from '@aws-cdk/integ-tests-alpha';
33
import { Alarm, Metric } from 'aws-cdk-lib/aws-cloudwatch';
44

55
class AlarmWithLabelIntegrationTest extends Stack {
6-
76
constructor(scope: App, id: string, props?: StackProps) {
87
super(scope, id, props);
98

packages/@aws-cdk-testing/framework-integ/test/aws-cloudwatch/test/integ.composite-alarm.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { IntegTest } from '@aws-cdk/integ-tests-alpha';
33
import { Alarm, AlarmRule, AlarmState, CompositeAlarm, Metric } from 'aws-cdk-lib/aws-cloudwatch';
44

55
class CompositeAlarmIntegrationTest extends Stack {
6-
76
constructor(scope: App, id: string, props?: StackProps) {
87
super(scope, id, props);
98

@@ -61,11 +60,9 @@ class CompositeAlarmIntegrationTest extends Stack {
6160
actionsSuppressor: alarm5,
6261
});
6362
}
64-
6563
}
6664

6765
class CompositeAlarmImportIntegrationTest extends Stack {
68-
6966
constructor(scope: App, id: string, props?: StackProps) {
7067
super(scope, id, props);
7168

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.dynamodb-v2.warm-throughput.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import * as dynamodb from 'aws-cdk-lib/aws-dynamodb';
44
import { IntegTest } from '@aws-cdk/integ-tests-alpha';
55

66
export class TestStack extends Stack {
7-
87
readonly table: dynamodb.TableV2;
98

109
constructor(scope: Construct, id: string, props?: StackProps) {

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.dynamodb.deletion-protection.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { Construct } from 'constructs';
44
import { AttributeType, Table } from 'aws-cdk-lib/aws-dynamodb';
55

66
export class TestStack extends Stack {
7-
87
readonly table: Table;
98
constructor(scope: Construct, id: string, props?: StackProps) {
109
super(scope, id, props);

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.dynamodb.policy.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import * as iam from 'aws-cdk-lib/aws-iam';
55
import { IntegTest } from '@aws-cdk/integ-tests-alpha';
66

77
export class TestStack extends Stack {
8-
98
readonly table: dynamodb.Table;
109
readonly tableTwo: dynamodb.Table;
1110

packages/@aws-cdk-testing/framework-integ/test/aws-dynamodb/test/integ.dynamodb.warm-throughput.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import * as dynamodb from 'aws-cdk-lib/aws-dynamodb';
44
import { IntegTest } from '@aws-cdk/integ-tests-alpha';
55

66
export class TestStack extends Stack {
7-
87
readonly table: dynamodb.Table;
98

109
constructor(scope: Construct, id: string, props?: StackProps) {

packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.vpc-dual-stack-ec2.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import * as path from 'path';
1212
const app = new cdk.App();
1313

1414
class EC2DualStack extends cdk.Stack {
15-
1615
public readonly instancePublicIp: string;
1716

1817
constructor(scope: Construct, id: string, props?: cdk.StackProps) {

packages/@aws-cdk-testing/framework-integ/test/aws-ec2/test/integ.vpc-endpoint-service.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ class TestStack extends cdk.Stack {
1919
contributorInsights: true,
2020
});
2121
}
22-
2322
}
2423

2524
const stack = new TestStack(app, 'TestStackLoadBalancer');

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/bucket-pinger/bucket-pinger.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ export interface BucketPingerProps {
1010
readonly timeout?: Duration;
1111
}
1212
export class BucketPinger extends Construct {
13-
1413
private _resource: CustomResource;
1514

1615
constructor(scope: Construct, id: string, props: BucketPingerProps) {

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.alb-controller.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import { IAM_OIDC_REJECT_UNAUTHORIZED_CONNECTIONS } from 'aws-cdk-lib/cx-api';
1111

1212
const LATEST_VERSION: eks.AlbControllerVersion = eks.AlbControllerVersion.V2_8_2;
1313
class EksClusterAlbControllerStack extends Stack {
14-
1514
constructor(scope: App, id: string) {
1615
super(scope, id);
1716

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-al2023-nodegroup.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import * as eks from 'aws-cdk-lib/aws-eks';
88
import { NodegroupAmiType } from 'aws-cdk-lib/aws-eks';
99

1010
class EksClusterStack extends Stack {
11-
1211
private cluster: eks.Cluster;
1312
private vpc: ec2.IVpc;
1413

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-bottlerocket-ng.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import * as eks from 'aws-cdk-lib/aws-eks';
88
import { NodegroupAmiType } from 'aws-cdk-lib/aws-eks';
99

1010
class EksClusterStack extends Stack {
11-
1211
private cluster: eks.Cluster;
1312
private vpc: ec2.IVpc;
1413

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-handlers-vpc.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import * as eks from 'aws-cdk-lib/aws-eks';
66
import { EC2_RESTRICT_DEFAULT_SECURITY_GROUP } from 'aws-cdk-lib/cx-api';
77

88
class EksAllHandlersInVpcStack extends Stack {
9-
109
constructor(scope: App, id: string) {
1110
super(scope, id);
1211

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-imported.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import * as constructs from 'constructs';
1717
import { IAM_OIDC_REJECT_UNAUTHORIZED_CONNECTIONS } from 'aws-cdk-lib/cx-api';
1818

1919
class EksClusterStack extends Stack {
20-
2120
private cluster: eks.Cluster;
2221
private importedCluster: eks.ICluster;
2322
private vpc: ec2.IVpc;

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-ipv6.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import * as eks from 'aws-cdk-lib/aws-eks';
1515
import { IAM_OIDC_REJECT_UNAUTHORIZED_CONNECTIONS } from 'aws-cdk-lib/cx-api';
1616

1717
class EksClusterStack extends Stack {
18-
1918
private cluster: eks.Cluster;
2019
private vpc: ec2.Vpc;
2120

@@ -347,7 +346,6 @@ class EksClusterStack extends Stack {
347346
});
348347

349348
}
350-
351349
}
352350

353351
// this test uses both the bottlerocket image and the inf1 instance, which are only supported in these

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-tags.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import * as eks from 'aws-cdk-lib/aws-eks';
66
import { getClusterVersionConfig } from './integ-tests-kubernetes-version';
77

88
class EksClusterTagsStack extends Stack {
9-
109
constructor(scope: App, id: string) {
1110
super(scope, id);
1211

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import * as eks from 'aws-cdk-lib/aws-eks';
1515
import { IAM_OIDC_REJECT_UNAUTHORIZED_CONNECTIONS } from 'aws-cdk-lib/cx-api';
1616

1717
class EksClusterStack extends Stack {
18-
1918
private cluster: eks.Cluster;
2019
private vpc: ec2.IVpc;
2120

@@ -339,7 +338,6 @@ class EksClusterStack extends Stack {
339338
});
340339

341340
}
342-
343341
}
344342

345343
// this test uses both the bottlerocket image and the inf1 instance, which are only supported in these

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-inference-nodegroup.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import * as eks from 'aws-cdk-lib/aws-eks';
77
import { IAM_OIDC_REJECT_UNAUTHORIZED_CONNECTIONS } from 'aws-cdk-lib/cx-api';
88

99
class EksClusterInferenceStack extends Stack {
10-
1110
constructor(scope: App, id: string) {
1211
super(scope, id);
1312

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-inference.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import * as eks from 'aws-cdk-lib/aws-eks';
77
import { IAM_OIDC_REJECT_UNAUTHORIZED_CONNECTIONS } from 'aws-cdk-lib/cx-api';
88

99
class EksClusterInferenceStack extends Stack {
10-
1110
constructor(scope: App, id: string) {
1211
super(scope, id);
1312

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-subnet-updates.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import * as integ from '@aws-cdk/integ-tests-alpha';
55
import { getClusterVersionConfig } from './integ-tests-kubernetes-version';
66

77
class EksClusterStack extends Stack {
8-
98
constructor(scope: App, id: string) {
109
super(scope, id);
1110

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-windows-ng.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { NodegroupAmiType, TaintEffect } from 'aws-cdk-lib/aws-eks';
99
import { EC2_RESTRICT_DEFAULT_SECURITY_GROUP } from 'aws-cdk-lib/cx-api';
1010

1111
class EksClusterStack extends Stack {
12-
1312
private cluster: eks.Cluster;
1413
private vpc: ec2.IVpc;
1514

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/pinger/pinger.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ export interface PingerProps {
1212
readonly subnets?: ec2.ISubnet[];
1313
}
1414
export class Pinger extends Construct {
15-
1615
private _resource: CustomResource;
1716

1817
constructor(scope: Construct, id: string, props: PingerProps) {

packages/@aws-cdk-testing/framework-integ/test/aws-events-targets/test/appsync/integ.appsync-events.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { IntegTest } from '@aws-cdk/integ-tests-alpha';
99
const app = new cdk.App();
1010

1111
class AwsAppSyncEvent extends cdk.Stack {
12-
1312
constructor(scope: cdk.App, id: string, props?: cdk.StackProps) {
1413
super(scope, id, props);
1514

packages/@aws-cdk-testing/framework-integ/test/aws-logs-destinations/test/integ.lambda.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import { LambdaDestination } from 'aws-cdk-lib/aws-logs-destinations';
1111
import { STANDARD_NODEJS_RUNTIME } from '../../config';
1212

1313
class LambdaStack extends Stack {
14-
1514
public readonly queue: sqs.Queue;
1615

1716
constructor(scope: constructs.Construct, id: string) {

packages/@aws-cdk-testing/framework-integ/test/custom-resources/test/provider-framework/integration-test-fixtures/s3-assert.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export interface S3AssertProps {
3131
* Code is written in Python because why not.
3232
*/
3333
export class S3Assert extends Construct {
34-
3534
constructor(scope: Construct, id: string, props: S3AssertProps) {
3635
super(scope, id);
3736

@@ -48,7 +47,6 @@ export class S3Assert extends Construct {
4847
}
4948

5049
class S3AssertProvider extends Construct {
51-
5250
/**
5351
* Returns the singleton provider.
5452
*/

packages/@aws-cdk-testing/framework-integ/test/custom-resources/test/provider-framework/integration-test-fixtures/s3-file.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ export class S3File extends Construct {
6060
}
6161

6262
class S3FileProvider extends Construct {
63-
6463
/**
6564
* Returns the singleton provider.
6665
*/

packages/@aws-cdk/aws-amplify-alpha/lib/domain.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ export interface DomainProps extends DomainOptions {
6666
* An Amplify Console domain
6767
*/
6868
export class Domain extends Resource {
69-
7069
/**
7170
* The ARN of the domain
7271
*

packages/@aws-cdk/aws-apprunner-alpha/lib/auto-scaling-configuration.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,5 +205,4 @@ export class AutoScalingConfiguration extends cdk.Resource implements IAutoScali
205205
throw new Error(`maxConcurrency must be between 1 and 200, got ${props.maxConcurrency}.`);
206206
}
207207
}
208-
209208
}

packages/@aws-cdk/aws-apprunner-alpha/lib/service.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ export class Memory {
166166
* The code runtimes
167167
*/
168168
export class Runtime {
169-
170169
/**
171170
* CORRETTO 8
172171
*/

packages/@aws-cdk/aws-codestar-alpha/lib/github-repository.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ export interface GitHubRepositoryProps {
8484
* The GitHubRepository resource
8585
*/
8686
export class GitHubRepository extends cdk.Resource implements IGitHubRepository {
87-
8887
public readonly owner: string;
8988
public readonly repo: string;
9089

packages/@aws-cdk/aws-cognito-identitypool-alpha/lib/identitypool-user-pool-authentication-provider.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ export interface UserPoolAuthenticationProviderBindConfig {
7878
* Defines a User Pool Authentication Provider
7979
*/
8080
export class UserPoolAuthenticationProvider implements IUserPoolAuthenticationProvider {
81-
8281
/**
8382
* The User Pool of the Associated Identity Providers
8483
*/

packages/@aws-cdk/aws-custom-resource-sdk-adapter/lib/api-call.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ export class ApiCall {
145145
throw Error(`No client constructor found within package: ${this.v3PackageName}`);
146146
}
147147
}
148-
149148
}
150149

151150
/**

packages/@aws-cdk/aws-custom-resource-sdk-adapter/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,4 +71,4 @@
7171
"publishConfig": {
7272
"tag": "latest"
7373
}
74-
}
74+
}

packages/@aws-cdk/aws-ec2-alpha/lib/ipam.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,6 @@ export interface IIpamScopeBase {
311311
* @internal
312312
*/
313313
class IpamPool extends Resource implements IIpamPool {
314-
315314
/**
316315
* Pool ID to be passed to the VPC construct
317316
* @attribute IpamPoolId
@@ -388,7 +387,6 @@ class IpamPool extends Resource implements IIpamPool {
388387
* @resource AWS::EC2::IPAMScope
389388
*/
390389
class IpamScope extends Resource implements IIpamScopeBase {
391-
392390
/**
393391
* Stores the reference to newly created Resource
394392
*/
@@ -434,7 +432,6 @@ class IpamScope extends Resource implements IIpamScopeBase {
434432
addPool(id: string, options: PoolOptions): IIpamPool {
435433
return createIpamPool(this.scope, id, this.props, options, this.scopeId);
436434
}
437-
438435
}
439436

440437
/**

packages/@aws-cdk/aws-ec2-alpha/lib/route.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,6 @@ export class VPNGatewayV2 extends Resource implements IRouteTarget {
383383
* @resource AWS::EC2::NatGateway
384384
*/
385385
export class NatGateway extends Resource implements IRouteTarget {
386-
387386
/**
388387
* Id of the NatGateway
389388
* @attribute
@@ -471,7 +470,6 @@ export class NatGateway extends Resource implements IRouteTarget {
471470
* @resource AWS::EC2::VPCPeeringConnection
472471
*/
473472
export class VPCPeeringConnection extends Resource implements IRouteTarget {
474-
475473
/**
476474
* The type of router used in the route.
477475
*/
@@ -563,7 +561,6 @@ export class VPCPeeringConnection extends Resource implements IRouteTarget {
563561

564562
return false;
565563
}
566-
567564
}
568565

569566
/**

0 commit comments

Comments
 (0)