Skip to content

Commit 6f106c7

Browse files
authored
revert: feat(cdk): update tsconfig to more modern settings in typescript init templates (#31953)
This reverts #31927 There are some TypeScript init tests failed. Revert the change for now so that it doesn't block the release. Will investigate why those test failed. ### Issue # (if applicable) Closes #<issue number here>. ### Reason for this change ### Description of changes ### Description of how you validated changes ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 3b28c50 commit 6f106c7

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

packages/aws-cdk/lib/init-templates/app/typescript/tsconfig.json

+6-2
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,17 @@
11
{
22
"compilerOptions": {
3-
"target": "ES2022",
3+
"target": "ES2020",
44
"module": "commonjs",
55
"lib": [
6-
"ES2023",
6+
"es2020",
77
"dom"
88
],
99
"declaration": true,
1010
"strict": true,
11+
"noImplicitAny": true,
12+
"strictNullChecks": true,
13+
"noImplicitThis": true,
14+
"alwaysStrict": true,
1115
"noUnusedLocals": false,
1216
"noUnusedParameters": false,
1317
"noImplicitReturns": true,

packages/aws-cdk/lib/init-templates/sample-app/typescript/tsconfig.json

+6-2
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,17 @@
11
{
22
"compilerOptions": {
3-
"target": "ES2022",
3+
"target": "ES2020",
44
"module": "commonjs",
55
"lib": [
6-
"ES2023",
6+
"es2020",
77
"dom"
88
],
99
"declaration": true,
1010
"strict": true,
11+
"noImplicitAny": true,
12+
"strictNullChecks": true,
13+
"noImplicitThis": true,
14+
"alwaysStrict": true,
1115
"noUnusedLocals": false,
1216
"noUnusedParameters": false,
1317
"noImplicitReturns": true,

0 commit comments

Comments
 (0)