Skip to content

Commit 69cff2e

Browse files
authored
fix(events-targets): hardcoded AWS partition in ECS task resource ARN (#29633)
### Issue # (if applicable) Closes #29610 Related to #28898 ### Reason for this change Previously the AWS partition was hardcoded so it would not work for other special partitions. ### Description of changes Replace hardcoded `aws` partition to be dynamically added with `this.cluster.stack.partition`. ### Description of how you validated changes Ran integ tests suite, no changes. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent b54f959 commit 69cff2e

File tree

21 files changed

+786
-739
lines changed

21 files changed

+786
-739
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/ec2/integ.scheduled-ecs-task.js.snapshot/aws-ecs-integ-ecs.assets.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/ec2/integ.scheduled-ecs-task.js.snapshot/aws-ecs-integ-ecs.template.json

+5-1
Original file line numberDiff line numberDiff line change
@@ -918,7 +918,11 @@
918918
"Fn::Join": [
919919
"",
920920
[
921-
"arn:aws:ecs:",
921+
"arn:",
922+
{
923+
"Ref": "AWS::Partition"
924+
},
925+
":ecs:",
922926
{
923927
"Ref": "AWS::Region"
924928
},

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/ec2/integ.scheduled-ecs-task.js.snapshot/manifest.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)