Skip to content

Commit 67bf448

Browse files
authored
chore(rds): migrate tests to use the Assertions module (#18606)
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 694c22b commit 67bf448

14 files changed

+264
-598
lines changed

packages/@aws-cdk/aws-rds/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
},
8080
"license": "Apache-2.0",
8181
"devDependencies": {
82-
"@aws-cdk/assert-internal": "0.0.0",
82+
"@aws-cdk/assertions": "0.0.0",
8383
"@aws-cdk/aws-events-targets": "0.0.0",
8484
"@aws-cdk/aws-lambda": "0.0.0",
8585
"@aws-cdk/cdk-build-tools": "0.0.0",

packages/@aws-cdk/aws-rds/test/cluster-engine.test.ts

+1-17
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import '@aws-cdk/assert-internal/jest';
21
import { AuroraEngineVersion, AuroraMysqlEngineVersion, AuroraPostgresEngineVersion, DatabaseClusterEngine } from '../lib';
32

43
describe('cluster engine', () => {
@@ -11,8 +10,6 @@ describe('cluster engine', () => {
1110

1211
// THEN
1312
expect(family).toEqual('aurora5.6');
14-
15-
1613
});
1714

1815
test("default parameterGroupFamily for versionless Aurora MySQL cluster engine is 'aurora-mysql5.7'", () => {
@@ -24,8 +21,6 @@ describe('cluster engine', () => {
2421

2522
// THEN
2623
expect(family).toEqual('aurora-mysql5.7');
27-
28-
2924
});
3025

3126
test('default parameterGroupFamily for versionless Aurora PostgreSQL is not defined', () => {
@@ -37,8 +32,6 @@ describe('cluster engine', () => {
3732

3833
// THEN
3934
expect(family).toEqual(undefined);
40-
41-
4235
});
4336

4437
test('cluster parameter group correctly determined for AURORA and given version', () => {
@@ -52,8 +45,6 @@ describe('cluster engine', () => {
5245

5346
// THEN
5447
expect(family).toEqual('aurora5.6');
55-
56-
5748
});
5849

5950
test('cluster parameter group correctly determined for AURORA_MYSQL and given version', () => {
@@ -67,8 +58,6 @@ describe('cluster engine', () => {
6758

6859
// THEN
6960
expect(family).toEqual('aurora-mysql5.7');
70-
71-
7261
});
7362

7463
test('cluster parameter group correctly determined for AURORA_MYSQL and given version 3', () => {
@@ -95,8 +84,6 @@ describe('cluster engine', () => {
9584

9685
// THEN
9786
expect(family).toEqual('aurora-postgresql11');
98-
99-
10087
});
10188

10289
test('parameter group family', () => {
@@ -117,15 +104,12 @@ describe('cluster engine', () => {
117104
'aurora-postgresql9.6');
118105
expect(DatabaseClusterEngine.auroraPostgres({ version: AuroraPostgresEngineVersion.of('10.0', '10') }).parameterGroupFamily).toEqual(
119106
'aurora-postgresql10');
120-
121-
122107
});
123108

124109
test('supported log types', () => {
125110
const mysqlLogTypes = ['error', 'general', 'slowquery', 'audit'];
126111
expect(DatabaseClusterEngine.aurora({ version: AuroraEngineVersion.VER_1_22_2 }).supportedLogTypes).toEqual(mysqlLogTypes);
127112
expect(DatabaseClusterEngine.auroraMysql({ version: AuroraMysqlEngineVersion.VER_2_08_1 }).supportedLogTypes).toEqual(mysqlLogTypes);
128113
expect(DatabaseClusterEngine.auroraPostgres({ version: AuroraPostgresEngineVersion.VER_9_6_9 }).supportedLogTypes).toEqual(['postgresql']);
129-
130114
});
131-
});
115+
});

0 commit comments

Comments
 (0)