Skip to content

Commit 623cedb

Browse files
feat(ecs-patterns): dualstack NLB (#30069)
### Issue # (if applicable) Closes #29614. ### Reason for this change Dualstack NLB is not supported in `NetworkLoadBalancedServiceBase`. ### Description of changes - Add `ipAddressType` to `NetworkLoadBalancedServiceBaseProps`. - default value is `IpAddressType.Ipv4` ### Description of how you validated changes Add both unit and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 411a58c commit 623cedb

22 files changed

+35452
-18
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/ec2/integ.network-load-balanced-ecs-service.js.snapshot/aws-ecs-integ-nlb.assets.json

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/ec2/integ.network-load-balanced-ecs-service.js.snapshot/aws-ecs-integ-nlb.template.json

+1
Original file line numberDiff line numberDiff line change
@@ -889,6 +889,7 @@
889889
"myServiceLB168895E1": {
890890
"Type": "AWS::ElasticLoadBalancingV2::LoadBalancer",
891891
"Properties": {
892+
"IpAddressType": "ipv4",
892893
"LoadBalancerAttributes": [
893894
{
894895
"Key": "deletion_protection.enabled",

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/ec2/integ.network-load-balanced-ecs-service.js.snapshot/cdk.out

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/ec2/integ.network-load-balanced-ecs-service.js.snapshot/integ.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/ec2/integ.network-load-balanced-ecs-service.js.snapshot/manifest.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/ec2/integ.network-load-balanced-ecs-service.js.snapshot/networkLoadBalancedEc2ServiceTestDefaultTestDeployAssert34DAD7DE.assets.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/ec2/integ.network-load-balanced-ecs-service.js.snapshot/tree.json

+23-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/ec2/integ.network-load-balanced-ecs-service.ts

+2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { Cluster, ContainerImage, AsgCapacityProvider, EcsOptimizedImage } from
44
import { App, Stack } from 'aws-cdk-lib';
55
import * as integ from '@aws-cdk/integ-tests-alpha';
66
import { NetworkLoadBalancedEc2Service } from 'aws-cdk-lib/aws-ecs-patterns';
7+
import { IpAddressType } from 'aws-cdk-lib/aws-elasticloadbalancingv2';
78

89
const app = new App();
910
const stack = new Stack(app, 'aws-ecs-integ-nlb');
@@ -56,6 +57,7 @@ new NetworkLoadBalancedEc2Service(stack, 'myService', {
5657
weight: 2,
5758
},
5859
],
60+
ipAddressType: IpAddressType.IPV4,
5961
});
6062

6163
new integ.IntegTest(app, 'networkLoadBalancedEc2ServiceTest', {

packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.nlb-ipv6.js.snapshot/NlbIpv6Stack.assets.json

+19
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)