Skip to content

Commit 5eeee75

Browse files
authored
chore: update stale pr workflow (#33537)
### Issue # (if applicable) Closes #<issue number here>. ### Reason for this change Messaging around stale PRs isn't clear, contributors don't always know what the next steps are if their PR is considered stale. Also, response time for contributors is too short. IMO 7 days isn't enough to get back to our comments as we sometimes take a long time to review PRs. Open to discussion on what the window for response time should be ### Description of changes ### Describe any new or updated permissions being added - Update which labels which should be skipped for stale PRs - Update merge conflict warning to be more clear about next steps - Update time given to contributors to respond ### Description of how you validated changes ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent bc91c70 commit 5eeee75

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

.github/workflows/close-stale-prs.yml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,18 @@ jobs:
1919
# appropriately.
2020
github-token: ${{ secrets.PROJEN_GITHUB_TOKEN }}
2121
stale-days: 21
22-
response-days: 7
22+
response-days: 14
2323

2424
# Optional
2525
important-checks-regex: AutoBuildv2Project1C6BFA3F
26+
merge-conflict-warning: |
27+
This PR cannot be merged because it has conflicts. Please resolve them. Note that PRs with merge conflicts considered stale and will be closed if not resolved.
28+
29+
To prevent automatic closure:
30+
- Fix merge conflicts
31+
- OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: <justification>"
32+
- OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: <question>"
33+
2634
warn-message: |
2735
This PR has been in the STATE state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing
2836
@@ -31,8 +39,8 @@ jobs:
3139
- OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: <justification>"
3240
- OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: <question>"
3341
34-
This PR will automatically close in 7 days if no action is taken.
42+
This PR will automatically close in 14 days if no action is taken.
3543
3644
close-message: This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.
37-
skip-labels: contribution/core,pr-linter/do-not-close,pr/needs-maintainer-review,pr-linter/exemption-requested
45+
skip-labels: contribution/core,pr-linter/do-not-close,pr/needs-maintainer-review,pr-linter/exemption-requested,pr/reviewer-clarification-requested,pr/needs-community-review,pr/work-in-progress
3846
close-label: closed-for-staleness

0 commit comments

Comments
 (0)