Skip to content

Commit 5c09893

Browse files
authored
chore(prlint): rename pr/needs-review to pr/needs-community-review (#26455)
Makes it less confusing ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 3e47d1b commit 5c09893

File tree

2 files changed

+19
-19
lines changed

2 files changed

+19
-19
lines changed

tools/@aws-cdk/prlint/lint.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ export class PullRequestLinter {
336336
*
337337
* In addition, we differentiate between ready for review by a core team member
338338
* (pr/needs-maintainer-review) or ready for review by core OR the trusted community
339-
* (pr/needs-review). A PR is prioritized for core team review when:
339+
* (pr/needs-community-review). A PR is prioritized for core team review when:
340340
*
341341
* 6. It links to a p1 issue
342342
* 7. It links to a p2 issue and has an approved community review
@@ -396,12 +396,12 @@ export class PullRequestLinter {
396396

397397
if (readyForReview && (fixesP1 || communityApproved)) {
398398
this.addLabel('pr/needs-maintainer-review', pr);
399-
this.removeLabel('pr/needs-review', pr);
399+
this.removeLabel('pr/needs-community-review', pr);
400400
} else if (readyForReview && !fixesP1) {
401401
this.removeLabel('pr/needs-maintainer-review', pr);
402-
this.addLabel('pr/needs-review', pr);
402+
this.addLabel('pr/needs-community-review', pr);
403403
} else {
404-
this.removeLabel('pr/needs-review', pr);
404+
this.removeLabel('pr/needs-community-review', pr);
405405
this.removeLabel('pr/needs-maintainer-review', pr);
406406
}
407407
}

tools/@aws-cdk/prlint/test/lint.test.ts

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ describe('integration tests required on features', () => {
541541
// THEN
542542
expect(mockAddLabel.mock.calls[0][0]).toEqual({
543543
"issue_number": 1234,
544-
"labels": ["pr/needs-review"],
544+
"labels": ["pr/needs-community-review"],
545545
"owner": "aws",
546546
"repo": "aws-cdk",
547547
});
@@ -577,7 +577,7 @@ describe('integration tests required on features', () => {
577577
});
578578
(pr as any).labels = [
579579
{
580-
name: 'pr/needs-review',
580+
name: 'pr/needs-community-review',
581581
}
582582
];
583583

@@ -592,7 +592,7 @@ describe('integration tests required on features', () => {
592592
// THEN
593593
expect(mockRemoveLabel.mock.calls[0][0]).toEqual({
594594
"issue_number": 1234,
595-
"name": "pr/needs-review",
595+
"name": "pr/needs-community-review",
596596
"owner": "aws",
597597
"repo": "aws-cdk",
598598
});
@@ -623,7 +623,7 @@ describe('integration tests required on features', () => {
623623
// THEN
624624
expect(mockAddLabel.mock.calls[0][0]).toEqual({
625625
"issue_number": 1234,
626-
"labels": ["pr/needs-review"],
626+
"labels": ["pr/needs-community-review"],
627627
"owner": "aws",
628628
"repo": "aws-cdk",
629629
});
@@ -645,7 +645,7 @@ describe('integration tests required on features', () => {
645645
name: 'pr-linter/exemption-requested',
646646
},
647647
{
648-
name: 'pr/needs-review',
648+
name: 'pr/needs-community-review',
649649
},
650650
];
651651

@@ -660,7 +660,7 @@ describe('integration tests required on features', () => {
660660
// THEN
661661
expect(mockRemoveLabel.mock.calls[0][0]).toEqual({
662662
"issue_number": 1234,
663-
"name": "pr/needs-review",
663+
"name": "pr/needs-community-review",
664664
"owner": "aws",
665665
"repo": "aws-cdk",
666666
});
@@ -678,7 +678,7 @@ describe('integration tests required on features', () => {
678678
});
679679
(pr as any).labels = [
680680
{
681-
name: 'pr/needs-review',
681+
name: 'pr/needs-community-review',
682682
}
683683
];
684684

@@ -693,7 +693,7 @@ describe('integration tests required on features', () => {
693693
// THEN
694694
expect(mockRemoveLabel.mock.calls[0][0]).toEqual({
695695
"issue_number": 1234,
696-
"name": "pr/needs-review",
696+
"name": "pr/needs-community-review",
697697
"owner": "aws",
698698
"repo": "aws-cdk",
699699
});
@@ -711,7 +711,7 @@ describe('integration tests required on features', () => {
711711
});
712712
(pr as any).labels = [
713713
{
714-
name: 'pr/needs-review',
714+
name: 'pr/needs-community-review',
715715
}
716716
];
717717

@@ -726,7 +726,7 @@ describe('integration tests required on features', () => {
726726
// THEN
727727
expect(mockRemoveLabel.mock.calls[0][0]).toEqual({
728728
"issue_number": 1234,
729-
"name": "pr/needs-review",
729+
"name": "pr/needs-community-review",
730730
"owner": "aws",
731731
"repo": "aws-cdk",
732732
});
@@ -749,7 +749,7 @@ describe('integration tests required on features', () => {
749749
});
750750
(pr as any).labels = [
751751
{
752-
name: 'pr/needs-review',
752+
name: 'pr/needs-community-review',
753753
}
754754
];
755755

@@ -764,7 +764,7 @@ describe('integration tests required on features', () => {
764764
// THEN
765765
expect(mockRemoveLabel.mock.calls[0][0]).toEqual({
766766
"issue_number": 1234,
767-
"name": "pr/needs-review",
767+
"name": "pr/needs-community-review",
768768
"owner": "aws",
769769
"repo": "aws-cdk",
770770
});
@@ -782,7 +782,7 @@ describe('integration tests required on features', () => {
782782
});
783783
(pr as any).labels = [
784784
{
785-
name: 'pr/needs-review',
785+
name: 'pr/needs-community-review',
786786
}
787787
];
788788

@@ -815,7 +815,7 @@ describe('integration tests required on features', () => {
815815
name: 'pr-linter/exemption-requested',
816816
},
817817
{
818-
name: 'pr/needs-review',
818+
name: 'pr/needs-community-review',
819819
}
820820
];
821821

@@ -826,7 +826,7 @@ describe('integration tests required on features', () => {
826826
// THEN
827827
expect(mockRemoveLabel.mock.calls[0][0]).toEqual({
828828
"issue_number": 1234,
829-
"name": "pr/needs-review",
829+
"name": "pr/needs-community-review",
830830
"owner": "aws",
831831
"repo": "aws-cdk",
832832
});

0 commit comments

Comments
 (0)