fix(lambda-nodejs): cannot use esbuildArgs with older esbuild versions (#19343)

Older `esbuild` versions do not support passing `--arg=true`, only
`--arg` is accepted.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: jogold

packages/@aws-cdk/aws-lambda-nodejs/lib/bundling.ts

@@ -199,7 +199,7 @@ export class Bundling implements cdk.BundlingOptions {
       ...this.props.charset ? [`--charset=${this.props.charset}`] : [],
       ...this.props.mainFields ? [`--main-fields=${this.props.mainFields.join(',')}`] : [],
       ...this.props.inject ? this.props.inject.map(i => `--inject:${i}`) : [],
-      ...this.props.esbuildArgs ? [Object.entries(this.props.esbuildArgs).map(([key, value]) => `${key}="${value}"`).join(' ')] : [],
+      ...this.props.esbuildArgs ? [toCliArgs(this.props.esbuildArgs)] : [],
     ];
 
     let depsCommand = '';
@@ -353,3 +353,17 @@ function toTarget(runtime: Runtime): string {
 
   return `node${match[1]}`;
 }
+
+function toCliArgs(esbuildArgs: { [key: string]: string | boolean }): string {
+  const args = [];
+
+  for (const [key, value] of Object.entries(esbuildArgs)) {
+    if (value === true || value === '') {
+      args.push(key);
+    } else if (value) {
+      args.push(`${key}="${value}"`);
+    }
+  }
+
+  return args.join(' ');
+}

packages/@aws-cdk/aws-lambda-nodejs/test/bundling.test.ts

@@ -213,7 +213,8 @@ test('esbuild bundling with esbuild options', () => {
     esbuildArgs: {
       '--log-limit': '0',
       '--resolve-extensions': '.ts,.js',
-      '--splitting': 'true',
+      '--splitting': true,
+      '--keep-names': '',
     },
   });
 
@@ -233,7 +234,7 @@ test('esbuild bundling with esbuild options', () => {
           '--log-level=silent --keep-names --tsconfig=/asset-input/lib/custom-tsconfig.ts',
           '--metafile=/asset-output/index.meta.json --banner:js="/* comments */" --footer:js="/* comments */"',
           '--charset=utf8 --main-fields=module,main --inject:./my-shim.js',
-          '--log-limit="0" --resolve-extensions=".ts,.js" --splitting="true"',
+          '--log-limit="0" --resolve-extensions=".ts,.js" --splitting --keep-names',
         ].join(' '),
       ],
     }),