Skip to content

Commit 569593c

Browse files
juanheynsjuanheyns
authored
fix(rds): publiclyAccessible=false set on an instance is ignored when cluster is placed in a public subnet (#28038)
This change fixes the incorrect behavior as explained in #28037. Using null coalescing operator in TypeScript will use the original value of `publiclyAccessible` set on the `ServerlessV2ClusterInstanceProps`. Closes #28037. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 8f60e94 commit 569593c

File tree

15 files changed

+3449
-15
lines changed

15 files changed

+3449
-15
lines changed

‎packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster-public-subnets.js.snapshot/asset.a099fdfc61c84ffc56cef4fb2c9472483623ac865ce5d8fca88c89cf60d48d03/__entrypoint__.js

+147
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster-public-subnets.js.snapshot/asset.a099fdfc61c84ffc56cef4fb2c9472483623ac865ce5d8fca88c89cf60d48d03/index.js

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster-public-subnets.js.snapshot/cdk.out

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster-public-subnets.js.snapshot/integ-aurora-pub-sn-cluster.assets.json

+32
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)