Skip to content

Commit 512f64e

Browse files
authored
fix(elasticloadbalancingv2): ALB listeners with multiple forwardi… (#25005)
…ng targets need weights specified The [ELB docs](https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-listeners.html#forward-actions) on this aren't explicit, but the examples do _not_ show a configuration with multiple targets, but no weighting. This change assigns a weight to the action, if one wasn't specified. If specifying stickiness, but no weight, the template will change. Fixes #24805. Results in CFN like LBListener49E825B4: Type: AWS::ElasticLoadBalancingV2::Listener Properties: DefaultActions: - ForwardConfig: TargetGroups: - TargetGroupArn: Ref: TargetGroupOne7810CAFB Weight: 1 - TargetGroupArn: Ref: TargetGroupTwo593946E1 Weight: 1 Type: forward ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 0a82ed5 commit 512f64e

File tree

12 files changed

+1905
-18
lines changed

12 files changed

+1905
-18
lines changed

packages/@aws-cdk-testing/framework-integ/package.json

+6-5
Original file line numberDiff line numberDiff line change
@@ -29,20 +29,21 @@
2929
},
3030
"license": "Apache-2.0",
3131
"devDependencies": {
32-
"@aws-cdk/cdk-build-tools": "0.0.0",
3332
"@aws-cdk/aws-batch-alpha": "0.0.0",
34-
"delay": "5.0.0",
35-
"@aws-cdk/pkglint": "0.0.0"
33+
"@aws-cdk/cdk-build-tools": "0.0.0",
34+
"@aws-cdk/integ-runner": "^0.0.0",
35+
"@aws-cdk/pkglint": "0.0.0",
36+
"delay": "5.0.0"
3637
},
3738
"dependencies": {
39+
"@aws-cdk/integ-tests-alpha": "0.0.0",
3840
"@aws-cdk/lambda-layer-kubectl-v24": "^2.0.100",
3941
"aws-cdk-lib": "0.0.0",
4042
"aws-sdk": "^2.1317.0",
4143
"aws-sdk-mock": "5.6.0",
4244
"cdk8s": "^2.7.15",
4345
"cdk8s-plus-24": "2.4.40",
44-
"constructs": "^10.0.0",
45-
"@aws-cdk/integ-tests-alpha": "0.0.0"
46+
"constructs": "^10.0.0"
4647
},
4748
"repository": {
4849
"url": "https://github.com/aws/aws-cdk.git",
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
{
2+
"version": "31.0.0",
3+
"files": {
4+
"5c6a6a70d3025d3d783370635c0a869082ae70a4c11b4e7a0f459cfc4daffb3b": {
5+
"source": {
6+
"path": "Basic.template.json",
7+
"packaging": "file"
8+
},
9+
"destinations": {
10+
"current_account-current_region": {
11+
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
12+
"objectKey": "5c6a6a70d3025d3d783370635c0a869082ae70a4c11b4e7a0f459cfc4daffb3b.json",
13+
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
14+
}
15+
}
16+
}
17+
},
18+
"dockerImages": {}
19+
}

0 commit comments

Comments
 (0)