chore: HTTP Namespace in Cluster (#23328)

---
Cluster doesn't behave right when you try to "enableCloudMapNamespace" with an HTTPNamespace.

And enablelcoudmap in base-service.ts for the service have some problems with using just an httpNameSpace.

- To enable Defaultcloudmap namespace to http with both public and private DNS here I added logic which handles httpNameSpace along with private DNS namespace and public DNS namespace.

- Updated Unit-test cases as well.

Below you can see yarn build && yarn test results.

<img width="755" alt="image" src="https://user-images.githubusercontent.com/115483524/207423568-2dd5942b-1153-4946-9d28-dde637bd27ee.png">


### All Submissions:

* [ x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: homakk

packages/@aws-cdk/aws-ecs/lib/base/base-service.ts

@@ -973,6 +973,10 @@ export abstract class BaseService extends Resource
       throw new Error('Cannot enable service discovery if a Cloudmap Namespace has not been created in the cluster.');
     }
 
+    if (sdNamespace.type === cloudmap.NamespaceType.HTTP) {
+      throw new Error('Cannot enable DNS service discovery for HTTP Cloudmap Namespace.');
+    }
+
     // Determine DNS type based on network mode
     const networkMode = this.taskDefinition.networkMode;
     if (networkMode === NetworkMode.NONE) {

packages/@aws-cdk/aws-ecs/lib/cluster.ts

@@ -288,8 +288,8 @@ export class Cluster extends Resource implements ICluster {
 
   /**
    * Add an AWS Cloud Map DNS namespace for this cluster.
-   * NOTE: HttpNamespaces are not supported, as ECS always requires a DNSConfig when registering an instance to a Cloud
-   * Map service.
+   * NOTE: HttpNamespaces are supported only for use cases involving Service Connect. For use cases involving both Service-
+   * Discovery and Service Connect, customers should manage the HttpNamespace outside of the Cluster.addDefaultCloudMapNamespace method.
    */
   public addDefaultCloudMapNamespace(options: CloudMapNamespaceOptions): cloudmap.INamespace {
     if (this._defaultCloudMapNamespace !== undefined) {
@@ -300,14 +300,27 @@ export class Cluster extends Resource implements ICluster {
       ? options.type
       : cloudmap.NamespaceType.DNS_PRIVATE;
 
-    const sdNamespace = namespaceType === cloudmap.NamespaceType.DNS_PRIVATE ?
-      new cloudmap.PrivateDnsNamespace(this, 'DefaultServiceDiscoveryNamespace', {
-        name: options.name,
-        vpc: this.vpc,
-      }) :
-      new cloudmap.PublicDnsNamespace(this, 'DefaultServiceDiscoveryNamespace', {
-        name: options.name,
-      });
+    let sdNamespace;
+    switch (namespaceType) {
+      case cloudmap.NamespaceType.DNS_PRIVATE:
+        sdNamespace = new cloudmap.PrivateDnsNamespace(this, 'DefaultServiceDiscoveryNamespace', {
+          name: options.name,
+          vpc: this.vpc,
+        });
+        break;
+      case cloudmap.NamespaceType.DNS_PUBLIC:
+        sdNamespace = new cloudmap.PublicDnsNamespace(this, 'DefaultServiceDiscoveryNamespace', {
+          name: options.name,
+        });
+        break;
+      case cloudmap.NamespaceType.HTTP:
+        sdNamespace = new cloudmap.HttpNamespace(this, 'DefaultServiceDiscoveryNamespace', {
+          name: options.name,
+        });
+        break;
+      default:
+        throw new Error(`Namespace type ${namespaceType} is not supported.`);
+    }
 
     this._defaultCloudMapNamespace = sdNamespace;
     if (options.useForServiceConnect) {

packages/@aws-cdk/aws-ecs/test/cluster.test.ts

@@ -1024,6 +1024,20 @@ describe('cluster', () => {
     expect((cluster as any)._cfnCluster.serviceConnectDefaults.namespace).toBe('foo.com');
   });
 
+  test('allows setting cluster _defaultCloudMapNamespace for HTTP namespace', () => {
+    // GIVEN
+    const stack = new cdk.Stack();
+    const vpc = new ec2.Vpc(stack, 'MyVpc', {});
+    const cluster = new ecs.Cluster(stack, 'EcsCluster', { vpc });
+    // WHEN
+    const namespace = cluster.addDefaultCloudMapNamespace({
+      name: 'foo',
+      type: cloudmap.NamespaceType.HTTP,
+    });
+    // THEN
+    expect(namespace.namespaceName).toBe('foo');
+  });
+
   /*
    * TODO:v2.0.0 END OF OBSOLETE BLOCK
    */

packages/@aws-cdk/aws-ecs/test/ec2/ec2-service.test.ts

@@ -2621,6 +2621,37 @@ describe('ec2 service', () => {
       }).toThrow(/Cannot enable service discovery if a Cloudmap Namespace has not been created in the cluster./);
 
 
+    });
+
+    test('fails to enable Service Discovery with HTTP defaultCloudmapNamespace', () => {
+      // GIVEN
+      const stack = new cdk.Stack();
+      const vpc = new ec2.Vpc(stack, 'MyVpc', {});
+      const cluster = new ecs.Cluster(stack, 'EcsCluster', { vpc });
+      addDefaultCapacityProvider(cluster, stack, vpc);
+      const taskDefinition = new ecs.Ec2TaskDefinition(stack, 'Ec2TaskDef', {
+        networkMode: ecs.NetworkMode.NONE,
+      });
+      const container = taskDefinition.addContainer('MainContainer', {
+        image: ecs.ContainerImage.fromRegistry('hello'),
+        memoryLimitMiB: 512,
+      });
+      container.addPortMappings({ containerPort: 8000 });
+
+      cluster.addDefaultCloudMapNamespace({ name: 'foo.com', type: cloudmap.NamespaceType.HTTP });
+
+      // THEN
+      expect(() => {
+        new ecs.Ec2Service(stack, 'Service', {
+          cluster,
+          taskDefinition,
+          cloudMapOptions: {
+            name: 'myApp',
+          },
+        });
+      }).toThrow(/Cannot enable DNS service discovery for HTTP Cloudmap Namespace./);
+
+
     });
 
     test('throws if network mode is none', () => {