chore(prlint): handle case where label does not exist (#25444)

Forgot to handle a case where the label does not exist on the pull request when trying to remove the label. Update to first check to make sure the label exists before removing it.

Author: corymhall

tools/@aws-cdk/prlint/lint.ts

@@ -361,13 +361,15 @@ export class PullRequestLinter {
         // or the PR linter failed and the user didn't request an exemption
         || (prLinterFailed && !userRequestsExemption)
     ) {
-      console.log(`removing labels from pr ${pr.number}`);
-      this.client.issues.removeLabel({
-        owner: this.prParams.owner,
-        repo: this.prParams.repo,
-        issue_number: pr.number,
-        name: 'pr/needs-review',
-      });
+      if (pr.labels.some(label => label.name === 'pr/needs-review')) {
+        console.log(`removing labels from pr ${pr.number}`);
+        this.client.issues.removeLabel({
+          owner: this.prParams.owner,
+          repo: this.prParams.repo,
+          issue_number: pr.number,
+          name: 'pr/needs-review',
+        });
+      }
       return;
     } else {
       console.log(`adding labels to pr ${pr.number}`);
@@ -445,9 +447,13 @@ export class PullRequestLinter {
     await this.communicateResult(validationCollector);
 
     // also assess whether the PR needs review or not
-    const state = await this.codeBuildJobSucceeded(sha);
-    if (state) {
-      await this.assessNeedsReview(pr);
+    try {
+      const state = await this.codeBuildJobSucceeded(sha);
+      if (state) {
+        await this.assessNeedsReview(pr);
+      }
+    } catch (e) {
+      console.log('assessing review failed: ', e);
     }
   }
 

tools/@aws-cdk/prlint/test/lint.test.ts

@@ -555,6 +555,11 @@ describe('integration tests required on features', () => {
           data: [{ id: 1111122222, user: { login: 'aws-cdk-automation' }, state: 'CHANGES_REQUESTED' }]
         }
       });
+      (pr as any).labels = [
+        {
+          name: 'pr/needs-review',
+        }
+      ];
 
       // WHEN
       const prLinter = configureMock(pr);
@@ -618,6 +623,9 @@ describe('integration tests required on features', () => {
       (pr as any).labels = [
         {
           name: 'pr-linter/exemption-requested',
+        },
+        {
+          name: 'pr/needs-review',
         }
       ];