Skip to content

Commit 32781f8

Browse files
bun913bun913
authored
fix(ec2): enable set throughput param to CfnVolume (#24118)
## EC2.Volume.throughput does not get passed on into CFN The throughput parameter of the Ec2.Volume class (L2 Construct) was not set to the CfnVolume parameter as described in #24107 Fixed it so that the value is set. Closes #24107 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 1a28d3d commit 32781f8

19 files changed

+793
-0
lines changed

‎packages/@aws-cdk/aws-ec2/lib/volume.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -620,6 +620,7 @@ export class Volume extends VolumeBase {
620620
multiAttachEnabled: props.enableMultiAttach ?? false,
621621
size: props.size?.toGibibytes({ rounding: SizeRoundingBehavior.FAIL }),
622622
snapshotId: props.snapshotId,
623+
throughput: props.throughput,
623624
volumeType: props.volumeType ?? EbsDeviceVolumeType.GENERAL_PURPOSE_SSD,
624625
});
625626
resource.applyRemovalPolicy(props.removalPolicy);

‎packages/@aws-cdk/aws-ec2/test/integ.volume.js.snapshot/VolumeTestDefaultTestDeployAssert896AAE82.assets.json

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
{
2+
"version": "30.0.0",
3+
"files": {
4+
"21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22": {
5+
"source": {
6+
"path": "VolumeTestDefaultTestDeployAssert896AAE82.template.json",
7+
"packaging": "file"
8+
},
9+
"destinations": {
10+
"current_account-current_region": {
11+
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
12+
"objectKey": "21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22.json",
13+
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
14+
}
15+
}
16+
}
17+
},
18+
"dockerImages": {}
19+
}

‎packages/@aws-cdk/aws-ec2/test/integ.volume.js.snapshot/VolumeTestDefaultTestDeployAssert896AAE82.template.json

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
{
2+
"Parameters": {
3+
"BootstrapVersion": {
4+
"Type": "AWS::SSM::Parameter::Value<String>",
5+
"Default": "/cdk-bootstrap/hnb659fds/version",
6+
"Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"
7+
}
8+
},
9+
"Rules": {
10+
"CheckBootstrapVersion": {
11+
"Assertions": [
12+
{
13+
"Assert": {
14+
"Fn::Not": [
15+
{
16+
"Fn::Contains": [
17+
[
18+
"1",
19+
"2",
20+
"3",
21+
"4",
22+
"5"
23+
],
24+
{
25+
"Ref": "BootstrapVersion"
26+
}
27+
]
28+
}
29+
]
30+
},
31+
"AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."
32+
}
33+
]
34+
}
35+
}
36+
}

‎packages/@aws-cdk/aws-ec2/test/integ.volume.js.snapshot/aws-cdk-ec2-volume-1.assets.json

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
{
2+
"version": "30.0.0",
3+
"files": {
4+
"d505fb8b23ebfd0467ebfb179ba7b56714072b4f413d1ee2c2a9465b284985ef": {
5+
"source": {
6+
"path": "aws-cdk-ec2-volume-1.template.json",
7+
"packaging": "file"
8+
},
9+
"destinations": {
10+
"current_account-current_region": {
11+
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
12+
"objectKey": "d505fb8b23ebfd0467ebfb179ba7b56714072b4f413d1ee2c2a9465b284985ef.json",
13+
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
14+
}
15+
}
16+
}
17+
},
18+
"dockerImages": {}
19+
}

‎packages/@aws-cdk/aws-ec2/test/integ.volume.js.snapshot/aws-cdk-ec2-volume-1.template.json

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
{
2+
"Resources": {
3+
"TestVolume24F725A4": {
4+
"Type": "AWS::EC2::Volume",
5+
"Properties": {
6+
"AvailabilityZone": "us-east-1a",
7+
"MultiAttachEnabled": false,
8+
"Size": 1,
9+
"Throughput": 200,
10+
"VolumeType": "gp3"
11+
},
12+
"UpdateReplacePolicy": "Retain",
13+
"DeletionPolicy": "Retain"
14+
}
15+
},
16+
"Parameters": {
17+
"BootstrapVersion": {
18+
"Type": "AWS::SSM::Parameter::Value<String>",
19+
"Default": "/cdk-bootstrap/hnb659fds/version",
20+
"Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"
21+
}
22+
},
23+
"Rules": {
24+
"CheckBootstrapVersion": {
25+
"Assertions": [
26+
{
27+
"Assert": {
28+
"Fn::Not": [
29+
{
30+
"Fn::Contains": [
31+
[
32+
"1",
33+
"2",
34+
"3",
35+
"4",
36+
"5"
37+
],
38+
{
39+
"Ref": "BootstrapVersion"
40+
}
41+
]
42+
}
43+
]
44+
},
45+
"AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."
46+
}
47+
]
48+
}
49+
}
50+
}

‎packages/@aws-cdk/aws-ec2/test/integ.volume.js.snapshot/cdk.out

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"version":"30.0.0"}

‎packages/@aws-cdk/aws-ec2/test/integ.volume.js.snapshot/integ.json

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{
2+
"version": "30.0.0",
3+
"testCases": {
4+
"VolumeTest/DefaultTest": {
5+
"stacks": [
6+
"aws-cdk-ec2-volume-1"
7+
],
8+
"assertionStack": "VolumeTest/DefaultTest/DeployAssert",
9+
"assertionStackName": "VolumeTestDefaultTestDeployAssert896AAE82"
10+
}
11+
}
12+
}

‎packages/@aws-cdk/aws-ec2/test/integ.volume.js.snapshot/manifest.json

Lines changed: 111 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,111 @@
1+
{
2+
"version": "30.0.0",
3+
"artifacts": {
4+
"aws-cdk-ec2-volume-1.assets": {
5+
"type": "cdk:asset-manifest",
6+
"properties": {
7+
"file": "aws-cdk-ec2-volume-1.assets.json",
8+
"requiresBootstrapStackVersion": 6,
9+
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version"
10+
}
11+
},
12+
"aws-cdk-ec2-volume-1": {
13+
"type": "aws:cloudformation:stack",
14+
"environment": "aws://unknown-account/unknown-region",
15+
"properties": {
16+
"templateFile": "aws-cdk-ec2-volume-1.template.json",
17+
"validateOnSynth": false,
18+
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-deploy-role-${AWS::AccountId}-${AWS::Region}",
19+
"cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-${AWS::Region}",
20+
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/d505fb8b23ebfd0467ebfb179ba7b56714072b4f413d1ee2c2a9465b284985ef.json",
21+
"requiresBootstrapStackVersion": 6,
22+
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version",
23+
"additionalDependencies": [
24+
"aws-cdk-ec2-volume-1.assets"
25+
],
26+
"lookupRole": {
27+
"arn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-lookup-role-${AWS::AccountId}-${AWS::Region}",
28+
"requiresBootstrapStackVersion": 8,
29+
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version"
30+
}
31+
},
32+
"dependencies": [
33+
"aws-cdk-ec2-volume-1.assets"
34+
],
35+
"metadata": {
36+
"/aws-cdk-ec2-volume-1/TestVolume/Resource": [
37+
{
38+
"type": "aws:cdk:logicalId",
39+
"data": "TestVolume24F725A4"
40+
}
41+
],
42+
"/aws-cdk-ec2-volume-1/BootstrapVersion": [
43+
{
44+
"type": "aws:cdk:logicalId",
45+
"data": "BootstrapVersion"
46+
}
47+
],
48+
"/aws-cdk-ec2-volume-1/CheckBootstrapVersion": [
49+
{
50+
"type": "aws:cdk:logicalId",
51+
"data": "CheckBootstrapVersion"
52+
}
53+
]
54+
},
55+
"displayName": "aws-cdk-ec2-volume-1"
56+
},
57+
"VolumeTestDefaultTestDeployAssert896AAE82.assets": {
58+
"type": "cdk:asset-manifest",
59+
"properties": {
60+
"file": "VolumeTestDefaultTestDeployAssert896AAE82.assets.json",
61+
"requiresBootstrapStackVersion": 6,
62+
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version"
63+
}
64+
},
65+
"VolumeTestDefaultTestDeployAssert896AAE82": {
66+
"type": "aws:cloudformation:stack",
67+
"environment": "aws://unknown-account/unknown-region",
68+
"properties": {
69+
"templateFile": "VolumeTestDefaultTestDeployAssert896AAE82.template.json",
70+
"validateOnSynth": false,
71+
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-deploy-role-${AWS::AccountId}-${AWS::Region}",
72+
"cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-${AWS::Region}",
73+
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22.json",
74+
"requiresBootstrapStackVersion": 6,
75+
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version",
76+
"additionalDependencies": [
77+
"VolumeTestDefaultTestDeployAssert896AAE82.assets"
78+
],
79+
"lookupRole": {
80+
"arn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-lookup-role-${AWS::AccountId}-${AWS::Region}",
81+
"requiresBootstrapStackVersion": 8,
82+
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version"
83+
}
84+
},
85+
"dependencies": [
86+
"VolumeTestDefaultTestDeployAssert896AAE82.assets"
87+
],
88+
"metadata": {
89+
"/VolumeTest/DefaultTest/DeployAssert/BootstrapVersion": [
90+
{
91+
"type": "aws:cdk:logicalId",
92+
"data": "BootstrapVersion"
93+
}
94+
],
95+
"/VolumeTest/DefaultTest/DeployAssert/CheckBootstrapVersion": [
96+
{
97+
"type": "aws:cdk:logicalId",
98+
"data": "CheckBootstrapVersion"
99+
}
100+
]
101+
},
102+
"displayName": "VolumeTest/DefaultTest/DeployAssert"
103+
},
104+
"Tree": {
105+
"type": "cdk:tree",
106+
"properties": {
107+
"file": "tree.json"
108+
}
109+
}
110+
}
111+
}

0 commit comments

Comments
 (0)