Skip to content

Commit 29254fe

Browse files
authored
chore: remove and ignore intermediate snapshots integration test snapshots (#22731)
When running integration tests, they are executed inside an intermediate directory named `cdk-integ.out.*`. These files should never be committed to version control. This change removes the last few accidentally committed files, and adds a global gitignore rule to prevent any files being added in future. The unit tests for `integ-runner` rely on these (fake) intermediate artifacts for assertions, so they are still included. However these aren't real integreation tests anyway. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 1c707eb commit 29254fe

File tree

8 files changed

+5
-419
lines changed

8 files changed

+5
-419
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ cdk.context.json
3434
.cdk.staging/
3535
cdk.out/
3636
*.tabl.json
37+
cdk-integ.out.*/
3738

3839
# Yarn error log
3940
yarn-error.log

packages/@aws-cdk/aws-lambda/test/cdk-integ.out/cdk.out

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/@aws-cdk/aws-lambda/test/cdk-integ.out/lambda-test-assets.assets.json

Lines changed: 0 additions & 32 deletions
This file was deleted.

packages/@aws-cdk/aws-lambda/test/cdk-integ.out/lambda-test-assets.template.json

Lines changed: 0 additions & 91 deletions
This file was deleted.

packages/@aws-cdk/aws-lambda/test/cdk-integ.out/manifest.json

Lines changed: 0 additions & 70 deletions
This file was deleted.

packages/@aws-cdk/aws-lambda/test/cdk-integ.out/tree.json

Lines changed: 0 additions & 143 deletions
This file was deleted.

packages/@aws-cdk/integ-runner/.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,11 @@ junit.xml
2727
# Ignore this symlink, we recreate it at test time
2828
test/test-archive-follow/data/linked
2929

30+
# These files are needed for unit tests
31+
!test/test-data/cdk-integ.out*/
32+
3033
!**/*.snapshot/**/asset.*/*.js
3134
!**/*.snapshot/**/asset.*/*.d.ts
3235

3336
!**/*.snapshot/**/asset.*/**
37+

0 commit comments

Comments
 (0)