Skip to content

Commit 25d193a

Browse files
authored
chore(CLI): nested stacks should be skipped by changeset diff (#28784)
#28741 accidentally broke the logic that skips them ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 1b6be8b commit 25d193a

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

packages/aws-cdk/lib/api/util/cloudformation.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ export async function createDiffChangeSet(options: PrepareChangeSetOptions): Pro
317317
// eslint-disable-next-line no-console
318318
debug('This stack contains one or more nested stacks, falling back to template-only diff...');
319319

320-
//return undefined;
320+
return undefined;
321321
}
322322
}
323323

packages/aws-cdk/test/diff.test.ts

-1
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,6 @@ Resources
350350
const plainTextOutput = buffer.data.replace(/\x1B\[[0-?]*[ -/]*[@-~]/g, '')
351351
.replace(/[ \t]+$/mg, '');
352352
expect(plainTextOutput.trim()).toEqual(`Stack Parent
353-
Could not create a change set, will base the diff on template differences (run again with -v to see the reason)
354353
Resources
355354
[~] AWS::CloudFormation::Stack AdditionChild
356355
└─ [~] Resources

0 commit comments

Comments
 (0)