revert(cfnspec): add CloudFormation documentation to L1 classes (#18177)

This reverts commit 0ed661d.

Its currently failing our pipeline with:

```console
#STDOUT> [INFO] Total time:  08:11 min
--
958 | #STDOUT> [INFO] Finished at: 2021-12-25T02:10:45Z
959 | #STDOUT> [INFO] ------------------------------------------------------------------------
960 | #STDOUT> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project lex: Compilation failure: Compilation failure:
961 | #STDOUT> [ERROR] /tmp/npm-packDT4j4g/_aws-cdk_aws-lex/src/main/java/software/amazon/awscdk/services/lex/CfnBot.java:[11584,39] illegal unicode escape
962 | #STDOUT> [ERROR] /tmp/npm-packDT4j4g/_aws-cdk_aws-lex/src/main/java/software/amazon/awscdk/services/lex/CfnBot.java:[13,1] illegal unicode escape
963 | #STDOUT> [ERROR] /tmp/npm-packDT4j4g/_aws-cdk_aws-lex/src/main/java/software/amazon/awscdk/services/lex/CfnBot.java:[11621,58] illegal unicode escape
964 | #STDOUT> [ERROR] /tmp/npm-packDT4j4g/_aws-cdk_aws-lex/src/main/java/software/amazon/awscdk/services/lex/CfnBot.java:[17,32] illegal unicode escape
```

Looks like the docs are adding some illegal characters. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: iliapolo

packages/@aws-cdk/cfnspec/build-tools/build.ts

@@ -17,7 +17,6 @@ async function main() {
 
   await generateResourceSpecification(inputDir, path.join(outDir, 'specification.json'));
   await mergeSpecificationFromDirs(path.join(inputDir, 'cfn-lint'), path.join(outDir, 'cfn-lint.json'));
-  await fs.copyFile(path.join(inputDir, 'cfn-docs', 'cfn-docs.json'), path.join(outDir, 'cfn-docs.json'));
 }
 
 /**

packages/@aws-cdk/cfnspec/lib/index.ts

@@ -12,15 +12,6 @@ export function specification(): schema.Specification {
   return require('../spec/specification.json');
 }
 
-/**
- * The complete AWS CloudFormation Resource specification, having any CDK patches and enhancements included in it.
- */
-export function docs(): schema.CloudFormationDocsFile {
-  // eslint-disable-next-line @typescript-eslint/no-require-imports
-  return require('../spec/cfn-docs.json');
-}
-
-
 /**
  * Return the resource specification for the given typename
  *
@@ -35,21 +26,6 @@ export function resourceSpecification(typeName: string): schema.ResourceType {
   return ret;
 }
 
-/**
- * Return documentation for the given type
- */
-export function typeDocs(resourceName: string, propertyTypeName?: string): schema.CloudFormationTypeDocs {
-  const key = propertyTypeName ? `${resourceName}.${propertyTypeName}` : resourceName;
-  const ret = docs().Types[key];
-  if (!ret) {
-    return {
-      description: '',
-      properties: {},
-    };
-  }
-  return ret;
-}
-
 /**
  * Get the resource augmentations for a given type
  */

packages/@aws-cdk/cfnspec/lib/schema/docs.ts

@@ -4,4 +4,3 @@ export * from './resource-type';
 export * from './specification';
 export * from './augmentation';
 export * from './cfn-lint';
-export * from './docs';

packages/@aws-cdk/cfnspec/lib/schema/index.ts

@@ -1,4 +1,4 @@
-import { schema, cfnLintAnnotations, typeDocs } from '@aws-cdk/cfnspec';
+import { schema, cfnLintAnnotations } from '@aws-cdk/cfnspec';
 import { CodeMaker } from 'codemaker';
 import * as genspec from './genspec';
 import { itemTypeNames, PropertyAttributeName, scalarTypeNames, SpecName } from './spec-utils';
@@ -115,7 +115,7 @@ export default class CodeGenerator {
     const name = genspec.CodeName.forResourceProperties(resourceContext);
 
     this.docLink(spec.Documentation,
-      `Properties for defining a \`${resourceContext.className}\``,
+      `Properties for defining a \`${resourceContext.specName!.fqn}\``,
       '',
       '@stability external');
     this.code.openBlock(`export interface ${name.className}`);
@@ -144,17 +144,15 @@ export default class CodeGenerator {
     container: Container): Dictionary<string> {
     const propertyMap: Dictionary<string> = {};
 
-    const docs = typeDocs(resource.specName?.fqn ?? '');
-
     Object.keys(propertiesSpec).sort(propertyComparator).forEach(propName => {
       this.code.line();
       const propSpec = propertiesSpec[propName];
-      const additionalDocs = docs.properties[propName] || quoteCode(resource.specName!.relativeName(propName).fqn);
+      const additionalDocs = resource.specName!.relativeName(propName).fqn;
       const newName = this.emitProperty({
         context: resource,
         propName,
         spec: propSpec,
-        additionalDocs,
+        additionalDocs: quoteCode(additionalDocs),
       },
       container,
       );
@@ -194,20 +192,15 @@ export default class CodeGenerator {
       this.code.line();
     }
 
-    const docs = typeDocs(cfnName);
-
     //
     // The class declaration representing this Resource
     //
 
-    this.docLink(spec.Documentation, ...[
+    this.docLink(spec.Documentation,
       `A CloudFormation \`${cfnName}\``,
       '',
-      ...docs.description.split('\n'),
-      '',
       `@cloudformationResource ${cfnName}`,
-      '@stability external',
-    ]);
+      '@stability external');
     this.openClass(resourceName, RESOURCE_BASE_CLASS);
 
     //
@@ -278,9 +271,7 @@ export default class CodeGenerator {
 
         this.code.line();
 
-        this.docLink(undefined,
-          docs.attributes?.[attributeName] ?? '',
-          `@cloudformationAttribute ${attributeName}`);
+        this.docLink(undefined, `@cloudformationAttribute ${attributeName}`);
         const attr = genspec.attributeDefinition(attributeName, attributeSpec);
 
         this.code.line(`public readonly ${attr.propertyName}: ${attr.attributeType};`);
@@ -856,25 +847,18 @@ export default class CodeGenerator {
     this.code.line();
     this.beginNamespace(typeName);
 
-    const docs = typeDocs(resourceContext.specName?.fqn ?? '', (typeName.specName as PropertyAttributeName | undefined)?.propAttrName);
-
-    this.docLink(
-      propTypeSpec.Documentation,
-      docs.description,
-      '@stability external',
-    );
+    this.docLink(propTypeSpec.Documentation, '@stability external');
     /*
     if (!propTypeSpec.Properties || Object.keys(propTypeSpec.Properties).length === 0) {
       this.code.line('// eslint-disable-next-line somethingsomething | A genuine empty-object type');
     }
     */
     this.code.openBlock(`export interface ${typeName.className}`);
     const conversionTable: Dictionary<string> = {};
-
     if (propTypeSpec.Properties) {
       Object.keys(propTypeSpec.Properties).forEach(propName => {
         const propSpec = propTypeSpec.Properties[propName];
-        const additionalDocs = docs.properties[propName] || quoteCode(`${typeName.fqn}.${propName}`);
+        const additionalDocs = quoteCode(`${typeName.fqn}.${propName}`);
         const newName = this.emitInterfaceProperty({
           context: resourceContext,
           propName,
@@ -966,23 +950,12 @@ export default class CodeGenerator {
   private docLink(link: string | undefined, ...before: string[]): void {
     if (!link && before.length === 0) { return; }
     this.code.line('/**');
-    before.flatMap(x => x.split('\n')).forEach(line => this.code.line(` * ${escapeDocText(line)}`.trimRight()));
+    before.forEach(line => this.code.line(` * ${line}`.trimRight()));
     if (link) {
-      if (before.length > 0) {
-        this.code.line(' *');
-      }
       this.code.line(` * @link ${link}`);
     }
     this.code.line(' */');
-
-    /**
-     * If '* /' occurs literally somewhere in the doc text, it will break the docstring parsing.
-     *
-     * Break up those characters by inserting a zero-width space.
-     */
-    function escapeDocText(x: string) {
-      return x.replace(/\*\//g, '*\u200b/');
-    }
+    return;
   }
 }