Skip to content

Commit 1e94267

Browse files
authored
fix(ecs): add feature flag and remove ecs default deployment alarm settings (#30217)
### Issue # (if applicable) Internal ticket tracking V1142791950 ### Reason for this change Originally in this PR #25840, we added default deployment alarm settings to fix an issue where adding deployment alarms, deploying your CFN stack, then removing the deployment alarms from the CFN template, and deploying again WILL NOT remove the deployment alarms from the service. ECS now already supports default deployment alarm settings. We will remove the default setting of deploymentAlarms. Reason for removing this default behaviour is for region build where the deployment alarm service may not be available in new regions but is set by default by CDK. ### Description of changes Remove default deployment alarm. ### Description of how you validated changes All new tests and integration tests pass. ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent e5fbafe commit 1e94267

File tree

375 files changed

+81454
-17344
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

375 files changed

+81454
-17344
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-ecs-deploy.js.snapshot/aws-cdk-codepipeline-ecs-deploy.template.json

-5
Original file line numberDiff line numberDiff line change
@@ -271,11 +271,6 @@
271271
"Ref": "EcsCluster97242B84"
272272
},
273273
"DeploymentConfiguration": {
274-
"Alarms": {
275-
"AlarmNames": [],
276-
"Enable": false,
277-
"Rollback": false
278-
},
279274
"MaximumPercent": 200,
280275
"MinimumHealthyPercent": 50
281276
},

packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-ecs-deploy.js.snapshot/cdk.out

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)