Skip to content

Commit 186dc32

Browse files
authored
chore: edit flow chart in contributing guide (#19901)
---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 31115d2 commit 186dc32

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

CONTRIBUTING.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -178,12 +178,14 @@ Below is a flow chart that describes how your PR may be treated by repository ma
178178
graph TD
179179
A[Incoming PR] -->B[Is an issue attached?]
180180
B -->|Yes - labels copied from issue| C[Is it labeled P1?]
181-
B -->|No - auto-labeled as P2| D["Is it trivial or effort/small?"]
181+
B -->|No - auto-labeled as P2| D["Is the effort small?"]
182182
C -->|Yes - P1| E[Is the PR build succeeding?]
183183
C -->|No - it is P2| D
184184
D -->|Yes| E
185-
D -->|No| F[Unfortunately, we don't have the time to review <br/> PRs that are large effort and low priority.]
186-
E -->|Yes| G[We will review your PR as soon as we can]
185+
D -->|No| F[Can you break down the PR into smaller chunks?]
186+
F --->|Yes| I[Please do. This will help get traction on your PR.]
187+
F -->|No| J[Try to garner community support on the issue you are <br/> trying to solve. With 20 +1s, the issue will be relabeled as P1.]
188+
E --->|Yes| G[We will review your PR as soon as we can]
187189
E -->|No| H[If the build is failing for more than 4 weeks <br/> without any work on it, we will close the PR.]
188190
```
189191

0 commit comments

Comments
 (0)