Skip to content

Commit 17c94eb

Browse files
authored
Core: Duration ISO-8601 docs links not French (#21922)
I noticed that the links on https://docs.aws.amazon.com/cdk/api/v1/docs/@aws-cdk_core.Duration.html and https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.Duration.html took me to the French-language version the ISO site, https://www.iso.org/fr/standard/70907.html, which surprised me. This changes that to remove `/fr` from the URL. (I haven't tested, but this might default to the right language for a user's browser, or always show English, but I think either of those are less surprising, given the rest of the CDK's docs are in English.) ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 86fcd4f commit 17c94eb

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/@aws-cdk/core/lib/duration.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export class Duration {
6262
/**
6363
* Parse a period formatted according to the ISO 8601 standard
6464
*
65-
* @see https://www.iso.org/fr/standard/70907.html
65+
* @see https://www.iso.org/standard/70907.html
6666
* @param duration an ISO-formtted duration to be parsed.
6767
* @returns the parsed `Duration`.
6868
*/
@@ -167,7 +167,7 @@ export class Duration {
167167
* Return an ISO 8601 representation of this period
168168
*
169169
* @returns a string starting with 'P' describing the period
170-
* @see https://www.iso.org/fr/standard/70907.html
170+
* @see https://www.iso.org/standard/70907.html
171171
*/
172172
public toIsoString(): string {
173173
if (this.amount === 0) { return 'PT0S'; }
@@ -190,7 +190,7 @@ export class Duration {
190190
* Return an ISO 8601 representation of this period
191191
*
192192
* @returns a string starting with 'P' describing the period
193-
* @see https://www.iso.org/fr/standard/70907.html
193+
* @see https://www.iso.org/standard/70907.html
194194
* @deprecated Use `toIsoString()` instead.
195195
*/
196196
public toISOString(): string {

0 commit comments

Comments
 (0)