Skip to content

Commit 1624ab6

Browse files
authored
fix(core): incorrect CloudFormation date formatting (#28149)
The trailing `Z` is now required: - [ExpirationDate](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-s3-bucket-rule.html#cfn-s3-bucket-rule-expirationdate) - [TransitionDate](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-s3-bucket-transition.html#cfn-s3-bucket-transition-transitiondate) Closes #28065, #28124. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 306c3f1 commit 1624ab6

File tree

16 files changed

+101
-82
lines changed

16 files changed

+101
-82
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-lambda/test/integ.autoscaling.lit.js.snapshot/aws-lambda-autoscaling.assets.json

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-lambda/test/integ.autoscaling.lit.js.snapshot/aws-lambda-autoscaling.template.json

+9
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,15 @@
132132
},
133133
"Schedule": "cron(0 20 * * ? *)",
134134
"ScheduledActionName": "ScaleDownAtNight"
135+
},
136+
{
137+
"EndTime": "2023-12-26T00:00:00Z",
138+
"ScalableTargetAction": {
139+
"MaxCapacity": 20
140+
},
141+
"Schedule": "cron(0 20 * * ? *)",
142+
"ScheduledActionName": "WithStartAndEnd",
143+
"StartTime": "2023-12-25T00:00:00Z"
135144
}
136145
],
137146
"ServiceNamespace": "lambda"

packages/@aws-cdk-testing/framework-integ/test/aws-lambda/test/integ.autoscaling.lit.js.snapshot/cdk.out

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-lambda/test/integ.autoscaling.lit.js.snapshot/integ.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-lambda/test/integ.autoscaling.lit.js.snapshot/manifest.json

+3-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-lambda/test/integ.autoscaling.lit.js.snapshot/tree.json

+50-41
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-lambda/test/integ.autoscaling.lit.ts

+7
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,13 @@ class TestStack extends cdk.Stack {
4242
maxCapacity: 20,
4343
});
4444

45+
scalingTarget.scaleOnSchedule('WithStartAndEnd', {
46+
schedule: appscaling.Schedule.cron({ hour: '20', minute: '0' }),
47+
startTime: new Date('2023-12-25'),
48+
endTime: new Date('2023-12-26'),
49+
maxCapacity: 20,
50+
});
51+
4552
new cdk.CfnOutput(this, 'FunctionName', {
4653
value: fn.functionName,
4754
});

packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/aws-cdk-s3.assets.json

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/aws-cdk-s3.template.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
"LifecycleConfiguration": {
77
"Rules": [
88
{
9-
"ExpirationDate": "2019-10-01T00:00:00",
9+
"ExpirationDate": "2019-10-01T00:00:00Z",
1010
"Status": "Enabled"
1111
},
1212
{
13-
"ExpirationDate": "2019-10-01T00:00:00",
13+
"ExpirationDate": "2019-10-01T00:00:00Z",
1414
"ObjectSizeGreaterThan": 500,
1515
"ObjectSizeLessThan": 600,
1616
"Status": "Enabled"

packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/cdk.out

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/cdkinteglifecycleDefaultTestDeployAssert83FA03B1.assets.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/integ.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/manifest.json

+4-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)