Skip to content

Commit 1581190

Browse files
chore(ec2): invalid Interface VPC Endpoints (#31441)
### Issue # (if applicable) None ### Reason for this change The wrong URLs were set for several Interface Endpoints, so I corrected them. For example, when retrieving the freetier endpoint via CLI, it shows as `aws.api.{region}.freetier`, but in CDK, it was set to `com.amazonaws.{region}.freetire`. I believe this correction might be a breaking change, but since the previous URLs likely wouldn't have allowed access anyway, I'm unsure how to proceed. Which of the following approaches would be best? - Directly fix the incorrect URLs (the current implementation) - Implement a feature flag - Deprecate the existing method and implement a new one ### Description of changes Update URL from `com.amazonaws.{region}.{service}` to `aws.api.{region}.{service}` - freetier - bcm-data-exports ### Description of how you validated changes I've executed `described-vpc-endpoint-services` CLI. ```sh ❯ aws ec2 describe-vpc-endpoint-services --filters Name=service-type,Values=Interface Name=owner,Values=amazon --region us-east-1 --query ServiceNames | grep aws.api "aws.api.us-east-1.bcm-data-exports", "aws.api.us-east-1.freetier", "aws.api.us-east-1.kendra-ranking", "aws.api.us-east-1.qbusiness", ``` ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent b3b9aa8 commit 1581190

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ export class InterfaceVpcEndpointAwsService implements IInterfaceVpcEndpointServ
306306
public static readonly BEDROCK_AGENT = new InterfaceVpcEndpointAwsService('bedrock-agent');
307307
public static readonly BEDROCK_AGENT_RUNTIME = new InterfaceVpcEndpointAwsService('bedrock-agent-runtime');
308308
public static readonly BEDROCK_RUNTIME = new InterfaceVpcEndpointAwsService('bedrock-runtime');
309-
public static readonly BILLING_AND_COST_MANAGEMENT_FREETIER = new InterfaceVpcEndpointAwsService('freetier');
309+
public static readonly BILLING_AND_COST_MANAGEMENT_FREETIER = new InterfaceVpcEndpointAwsService('freetier', 'aws.api');
310310
public static readonly BILLING_AND_COST_MANAGEMENT_TAX = new InterfaceVpcEndpointAwsService('tax');
311311
public static readonly BILLING_CONDUCTOR = new InterfaceVpcEndpointAwsService('billingconductor');
312312
public static readonly BRAKET = new InterfaceVpcEndpointAwsService('braket');
@@ -366,7 +366,7 @@ export class InterfaceVpcEndpointAwsService implements IInterfaceVpcEndpointServ
366366
public static readonly CONTROL_CATALOG = new InterfaceVpcEndpointAwsService('controlcatalog');
367367
public static readonly COST_EXPLORER = new InterfaceVpcEndpointAwsService('ce');
368368
public static readonly DATA_EXCHANGE = new InterfaceVpcEndpointAwsService('dataexchange');
369-
public static readonly DATA_EXPORTS = new InterfaceVpcEndpointAwsService('bcm-data-exports');
369+
public static readonly DATA_EXPORTS = new InterfaceVpcEndpointAwsService('bcm-data-exports', 'aws.api');
370370
public static readonly DATASYNC = new InterfaceVpcEndpointAwsService('datasync');
371371
public static readonly DATAZONE = new InterfaceVpcEndpointAwsService('datazone');
372372
public static readonly DATABASE_MIGRATION_SERVICE = new InterfaceVpcEndpointAwsService('dms');

0 commit comments

Comments
 (0)