Skip to content

Commit 1057ef0

Browse files
authored
feat(cli): declare cdk import stable (#27390)
The `cdk import` feature has existed for a year and a half. Since then, we've only had one major bug report around multiple identifiers (#20895) which was fixed half a year ago. This feature seems solid enough to remove the "Preview" label. There is only one remaining limitation around Nested Stacks, but this feature could be addressed without breaking backwards compatibility. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 0bb49b4 commit 1057ef0

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

packages/aws-cdk/README.md

+9-9
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ For this reason, only use it for development purposes.
431431
**⚠ Note #2**: This command is considered experimental,
432432
and might have breaking changes in the future.
433433

434-
**⚠ Note #3**: Expected defaults for certain parameters may be different with the hotswap parameter. For example, an ECS service's minimum healthy percentage will currently be set to 0. Please review the source accordingly if this occurs.
434+
**⚠ Note #3**: Expected defaults for certain parameters may be different with the hotswap parameter. For example, an ECS service's minimum healthy percentage will currently be set to 0. Please review the source accordingly if this occurs.
435435

436436
### `cdk watch`
437437

@@ -548,17 +548,17 @@ To import an existing resource to a CDK stack, follow the following steps:
548548

549549
#### Limitations
550550

551-
This feature is currently in preview. Be aware of the following limitations:
551+
This feature currently has the following limitations:
552552

553-
- Importing resources in nested stacks is not possible.
554-
- Uses the deploy role credentials (necessary to read the encrypted staging
555-
bucket). Requires a new version (version 12) of the bootstrap stack, for the added
556-
IAM permissions to the `deploy-role`.
553+
- Importing resources into nested stacks is not possible.
557554
- There is no check on whether the properties you specify are correct and complete
558555
for the imported resource. Try starting a drift detection operation after importing.
559556
- Resources that depend on other resources must all be imported together, or one-by-one
560-
in the right order. The CLI will not help you import dependent resources in the right
561-
order, the CloudFormation deployment will fail with unresolved references.
557+
in the right order. If you do not, the CloudFormation deployment will fail
558+
with unresolved references.
559+
- Uses the deploy role credentials (necessary to read the encrypted staging
560+
bucket). Requires version 12 of the bootstrap stack, for the added
561+
IAM permissions to the `deploy-role`.
562562

563563
### `cdk destroy`
564564

@@ -619,7 +619,7 @@ boundaries see the [Security And Safety Dev Guide](https://github.com/aws/aws-cd
619619

620620
Once a bootstrap template has been deployed with a set of parameters, you must
621621
use the `--no-previous-parameters` CLI flag to change any of these parameters on
622-
future deployments.
622+
future deployments.
623623

624624
> **Note** Please note that when you use this flag, you must resupply
625625
>*all* previously supplied parameters.

packages/aws-cdk/lib/cdk-toolkit.ts

-1
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,6 @@ export class CdkToolkit {
479479
}
480480

481481
public async import(options: ImportOptions) {
482-
print(chalk.grey("The 'cdk import' feature is currently in preview."));
483482
const stacks = await this.selectStacksForDeploy(options.selector, true, true);
484483

485484
if (stacks.stackCount > 1) {

0 commit comments

Comments
 (0)