You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There were two problems:
1. The test compares against bootstrap stack version `22`. This will break once we bump the bootstrap stack version. Changed range to `<1999` to include all possible future versions.
2. The CLI and Framework notices are not displayed because in the pipeline, their version is suffixed with `-rc.1`, and apparently `semver` doesn't match against those.
> `semver.satisfies('2.16.0-rc.0', '<99.0.0') // false`
> `semver.satisfies('2.16.0', '<99.0.0') // true`
I don't see a quick way around this so I just removed those notices from the test. We have plenty of unit tests to cover this so i'm not too concerned. Note that this means our notices mechanism isn't able to match against pre-releases, this had always been the case and is ok since we don't publish our pre-releases.
### Checklist
- [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
0 commit comments