Skip to content

Commit 0b8f31d

Browse files
fix(eks): undefined constructor in custom resource (#26782)
When we [upgraded the proxy-agent v6](#26722) we did not update how we were importing from the package. Where [in 5.0 commonjs exports were used](https://github.com/TooTallNate/node-proxy-agent/blob/5.0.0/index.js#L25) , in [6.0 a named esm export is used](https://github.com/TooTallNate/proxy-agents/blob/proxy-agent%406.1.0/packages/proxy-agent/src/index.ts#L71). Updated to use a named import statement instead of a default require. Typescript also confirms the old import was an error now since we use `import` instead of `require`. Fixes: #26771 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent cef7136 commit 0b8f31d

27 files changed

+91
-93
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.js.snapshot/asset.acb2f8cda93fc5e8f324cbdf29471a1182441f7707645a562b4d29eb57c80eea/index.js

+68
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,14 @@ import { EKS } from '@aws-sdk/client-eks';
55
import { fromTemporaryCredentials } from '@aws-sdk/credential-providers';
66
// eslint-disable-next-line import/no-extraneous-dependencies
77
import { NodeHttpHandler } from '@aws-sdk/node-http-handler';
8+
// eslint-disable-next-line import/no-extraneous-dependencies
9+
import { ProxyAgent } from 'proxy-agent';
810
import { ClusterResourceHandler } from './cluster';
911
import { EksClient } from './common';
1012
import * as consts from './consts';
1113
import { FargateProfileResourceHandler } from './fargate';
1214
import { IsCompleteResponse } from '../../../custom-resources/lib/provider-framework/types';
1315

14-
// eslint-disable-next-line @typescript-eslint/no-require-imports, import/no-extraneous-dependencies
15-
const ProxyAgent = require('proxy-agent');
16-
1716
const proxyAgent = new ProxyAgent();
1817
const awsConfig = {
1918
logger: console,

packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.js.snapshot/asset.bb544555825b6abfdf2cf0c13f9410a77d62ad0fe0bf5c38cef55631cf427f31/index.js

-68
This file was deleted.

0 commit comments

Comments
 (0)