Skip to content

Commit 0b241d9

Browse files
authored
chore: call out requirement for allowing commits to your pr branch in contributing guide (#27072)
The new markdown syntax is from [here](https://github.com/orgs/community/discussions/16925) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 0bac8a5 commit 0b241d9

File tree

1 file changed

+15
-4
lines changed

1 file changed

+15
-4
lines changed

CONTRIBUTING.md

+15-4
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,17 @@ CDK integration tests.
487487

488488
* Create a commit with your changes and push them to a
489489
[fork](https://docs.github.com/en/get-started/quickstart/fork-a-repo).
490-
> Note: CDK core members can push to a branch on the AWS CDK repo (naming convention: `<user>/<feature-bug-name>`).
490+
> [!IMPORTANT]
491+
> We will not be able to accept your contribution if you do not allow commits to your PR branch, as it introduces
492+
> friction in our review process and breaks our automation that syncs with the main branch. In these scenarios, we will close
493+
> your pull request and ask that you recreate it with the necessary permissions.
494+
> This means that you must contribute from a fork within your personal account (as opposed to an organization owned account) and also develop
495+
> your contribution on a branch other than `main`. See
496+
> [Allowing changes to a pull request branch created from a fork](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
497+
> for more information.
498+
499+
> [!NOTE]
500+
> CDK core members can push to a branch on the AWS CDK repo (naming convention: `<user>/<feature-bug-name>`).
491501
492502
* Create a [pull request on
493503
Github](https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork).
@@ -593,9 +603,10 @@ dependency.**
593603

594604
#### Adding new unconventional dependencies
595605

596-
> :warning: Do not add these. If there is a tool that you want to use in your
597-
CDK constructs, see [Adding construct runtime
598-
dependencies](#Adding-construct-runtime-dependencies).
606+
> [!WARNING]
607+
> Do not add these. If there is a tool that you want to use in your
608+
> CDK constructs, see [Adding construct runtime
609+
> dependencies](#Adding-construct-runtime-dependencies).
599610
600611
**For the aws-cdk an unconventional dependency is defined as any dependency that is not managed via the module's
601612
`package.json` file.**

0 commit comments

Comments
 (0)