Skip to content

Commit 07f2d7b

Browse files
authored
fix(eks): integ tests errors (#24276)
This PR fixes the integ tests errors in aws-eks and addresses the following issues: `integ.alb-controller.ts` has `runAsNonRoot` error and should define a non-root user in securityContext of the pod definition to ensure successful k8s deployment. `integ.eks-service-account-sdk-call.ts` should define a non-root user as well and increase the timeout of `BucketPinger` from the default 1 min to 3 min as the deployment could take up to 2 minutes or more. The base docker image from docker hub for this test has been replaced with the same image in ECR public to avoid potential throttling. I have manually run the two integ tests in my account and both successfully deploy with no error now. Closes #24266 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 549f912 commit 07f2d7b

File tree

88 files changed

+1008
-1526
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

88 files changed

+1008
-1526
lines changed

Diff for: packages/@aws-cdk/aws-eks/test/bucket-pinger/bucket-pinger.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { Construct } from 'constructs';
66

77
export interface BucketPingerProps {
88
readonly bucketName: string;
9+
readonly timeout?: Duration;
910
}
1011
export class BucketPinger extends Construct {
1112

@@ -18,7 +19,7 @@ export class BucketPinger extends Construct {
1819
code: lambda.Code.fromAsset(`${__dirname}/function`),
1920
handler: 'index.handler',
2021
runtime: lambda.Runtime.PYTHON_3_9,
21-
timeout: Duration.minutes(1),
22+
timeout: props.timeout ?? Duration.minutes(1),
2223
environment: {
2324
BUCKET_NAME: props.bucketName,
2425
},

Diff for: packages/@aws-cdk/aws-eks/test/integ.alb-controller.js.snapshot/asset.7215c88dd3e638d28329d4538b36cdbfb54233a4d972181795814f8b904d1037/outbound.js

-45
This file was deleted.

Diff for: packages/@aws-cdk/aws-eks/test/integ.alb-controller.js.snapshot/asset.73edfa4462023915a2f13bf570acae05c5111817c606f9837f832152920ba517/cluster.js

-267
This file was deleted.

0 commit comments

Comments
 (0)