Skip to content

Commit 04a9302

Browse files
chore: use @types/conventional-commits-parser instead of decs file (#24239)
With the upgrade in esbuild, this file no longer functions correctly. DefinitelyTyped provides types for this, though, so we should use those. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 853e3d6 commit 04a9302

File tree

7 files changed

+16
-21
lines changed

7 files changed

+16
-21
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"postinstall": "patch-package --error-on-fail"
1717
},
1818
"devDependencies": {
19-
"@types/node": "18.11.18",
19+
"@types/node": "18.11.19",
2020
"@types/prettier": "2.6.0",
2121
"@yarnpkg/lockfile": "^1.1.0",
2222
"cdk-generate-synthetic-examples": "^0.1.155",

packages/@aws-cdk/aws-amplifyuibuilder/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
"@aws-cdk/cfn2ts": "0.0.0",
9090
"@aws-cdk/pkglint": "0.0.0",
9191
"@types/jest": "^27.5.2",
92-
"@types/node": "18.11.18"
92+
"@types/node": "18.11.19"
9393
},
9494
"dependencies": {
9595
"@aws-cdk/core": "0.0.0",

tools/@aws-cdk/node-bundle/package.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tools/@aws-cdk/prlint/decs.d.ts

-13
This file was deleted.

tools/@aws-cdk/prlint/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
"glob": "^7.2.3"
1919
},
2020
"devDependencies": {
21+
"@types/conventional-commits-parser": "3.0.2",
2122
"@types/fs-extra": "^9.0.13",
2223
"@types/glob": "^7.2.0",
2324
"@types/jest": "^27.5.2",

tools/@aws-cdk/yarn-cling/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"devDependencies": {
4040
"@aws-cdk/pkglint": "0.0.0",
4141
"@types/jest": "^27.5.2",
42-
"@types/node": "18.11.18",
42+
"@types/node": "18.11.19",
4343
"@types/semver": "^7.3.13",
4444
"@types/yarnpkg__lockfile": "^1.1.5",
4545
"jest": "^27.5.1",

yarn.lock

+11-4
Original file line numberDiff line numberDiff line change
@@ -2009,6 +2009,13 @@
20092009
resolved "https://registry.npmjs.org/@types/changelog-parser/-/changelog-parser-2.8.1.tgz#294f63a1d54af24ee73e600c1a0d4ba7ca9c2516"
20102010
integrity sha512-Wul8tHLumoC7mauxXzPbtBLC2KuY5NZ2w6BlRYnOM53oZz5mz7oUGsYL4l8bKzZzIX7y2vO7Y4/2K8qICJjckw==
20112011

2012+
2013+
version "3.0.2"
2014+
resolved "https://registry.npmjs.org/@types/conventional-commits-parser/-/conventional-commits-parser-3.0.2.tgz#144b208c7344838bb045860fe1ddd10d4ae68f7c"
2015+
integrity sha512-1kVPUHFaart1iGRFxKn8WNXYEDVAgMb+DLatgql2dGg9jTGf3bNxWtN//C/tDG3ckOLg4u7SSx+qcn8VjzI5zg==
2016+
dependencies:
2017+
"@types/node" "*"
2018+
20122019
"@types/eslint@^7.29.0":
20132020
version "7.29.0"
20142021
resolved "https://registry.npmjs.org/@types/eslint/-/eslint-7.29.0.tgz#e56ddc8e542815272720bb0b4ccc2aff9c3e1c78"
@@ -2148,10 +2155,10 @@
21482155
resolved "https://registry.npmjs.org/@types/node/-/node-18.13.0.tgz#0400d1e6ce87e9d3032c19eb6c58205b0d3f7850"
21492156
integrity sha512-gC3TazRzGoOnoKAhUx+Q0t8S9Tzs74z7m0ipwGpSqQrleP14hKxP4/JUeEQcD3W1/aIpnWl8pHowI7WokuZpXg==
21502157

2151-
"@types/[email protected].18":
2152-
version "18.11.18"
2153-
resolved "https://registry.npmjs.org/@types/node/-/node-18.11.18.tgz#8dfb97f0da23c2293e554c5a50d61ef134d7697f"
2154-
integrity sha512-DHQpWGjyQKSHj3ebjFI/wRKcqQcdR+MoFBygntYOZytCqNfkd2ZC4ARDJ2DQqhjH5p85Nnd3jhUJIXrszFX/JA==
2158+
"@types/[email protected].19":
2159+
version "18.11.19"
2160+
resolved "https://registry.npmjs.org/@types/node/-/node-18.11.19.tgz#35e26df9ec441ab99d73e99e9aca82935eea216d"
2161+
integrity sha512-YUgMWAQBWLObABqrvx8qKO1enAvBUdjZOAWQ5grBAkp5LQv45jBvYKZ3oFS9iKRCQyFjqw6iuEa1vmFqtxYLZw==
21552162

21562163
"@types/node@^16.9.2":
21572164
version "16.18.12"

0 commit comments

Comments
 (0)