fix(integ-tests): tests need to mved before they can be run (#439)

For historical reasons of working with Jest 27 or lower, we needed to
`mv` the `integ-tests` out of an install directory where they would be
left by an `npm install`. The reason was that Jest 27 or lower would
always ignore all `node_modules` direcotries, and so could not be
configured to run tests from an install location.

Since we are on Jest 29, we can now lift this limitation with the right
configuration options. We can run the tests directly from the
`node_modules` directory and don't have to fiddle around with moving
files anymore.


---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Signed-off-by: github-actions <[email protected]>
Co-authored-by: github-actions <[email protected]>

Author: rix0rrr

.github/workflows/integ.yml

@@ -3,12 +3,6 @@ const os = require('os');
 
 const rootDir = path.resolve(__dirname, '..', 'tests', process.env.TEST_SUITE_NAME);
 
-if (rootDir.includes('node_modules')) {
-  // Jest < 28 under no circumstances supports loading test if there's node_modules anywhere in the path,
-  // and Jest >= 28 requires a newer TypeScript version than the one we support.
-  throw new Error(`This package must not be 'npm install'ed (found node_modules in dir: ${rootDir})`);
-}
-
 module.exports = {
   rootDir,
   testMatch: [`**/*.integtest.js`],
@@ -24,7 +18,15 @@ module.exports = {
   reporters: [
     "default",
     ["jest-junit", { suiteName: "jest tests", outputDirectory: "coverage" }]
-  ]
+  ],
+
+  // Both of the following things are necessary to discover test files that are
+  // potentially installed into `node_modules`.
+  testPathIgnorePatterns: [],
+  haste: {
+    // Necessary to include files in 'node_modules' where we may be installed.
+    retainAllFiles: true,
+  },
 };
 
 /**

packages/@aws-cdk-testing/cli-integ/resources/integ.jest.config.js

@@ -376,10 +376,6 @@ export class CdkCliIntegTestsWorkflow extends Component {
           name: 'Download and install the test artifact',
           run: [
             'npm install @aws-cdk-testing/cli-integ',
-            // Move the installed files to the current directory, because as
-            // currently configured the tests won't run from an installed
-            // node_modules directory.
-            'mv ./node_modules/@aws-cdk-testing/cli-integ/* .',
           ].join('\n'),
         },
         {
@@ -397,7 +393,7 @@ export class CdkCliIntegTestsWorkflow extends Component {
         {
           name: 'Run the test suite: ${{ matrix.suite }}',
           run: [
-            `bin/run-suite${maxWorkersArg} --use-cli-release=\${{ steps.versions.outputs.cli_version }} --framework-version=\${{ steps.versions.outputs.lib_version }} \${{ matrix.suite }}`,
+            `npx run-suite${maxWorkersArg} --use-cli-release=\${{ steps.versions.outputs.cli_version }} --framework-version=\${{ steps.versions.outputs.lib_version }} \${{ matrix.suite }}`,
           ].join('\n'),
           env: {
             JSII_SILENCE_WARNING_DEPRECATED_NODE_VERSION: 'true',