Skip to content

Commit cce3aef

Browse files
rix0rrrgithub-actions
and
github-actions
authored
chore: use >= for dependencies on cloud-assembly-schema (#359)
By default we would use `^41.0.0` to depend on this package, but it is strictly backwards compatible. The major version number of this package currently tracks the revision of the cloud assembly protocol, and does not use semver major versions to indicate breaking changes (breaking changes are not allowed). We should use `>=` to indicate that we expect a minimum version of the schema, but we don't want to imply a maximum version. Relates to #345. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
1 parent 3ca351b commit cce3aef

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

.projenrc.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@ const cdkAssets = configureProject(
583583
description: 'CDK Asset Publishing Tool',
584584
srcdir: 'lib',
585585
deps: [
586-
cloudAssemblySchema.customizeReference({ versionType: 'exact' }),
586+
cloudAssemblySchema.customizeReference({ versionType: 'minimal' }),
587587
cxApi,
588588
'archiver',
589589
'glob',
@@ -1130,7 +1130,7 @@ const cli = configureProject(
11301130
'xml-js',
11311131
],
11321132
deps: [
1133-
cloudAssemblySchema.customizeReference({ versionType: 'exact' }),
1133+
cloudAssemblySchema.customizeReference({ versionType: 'minimal' }),
11341134
cloudFormationDiff.customizeReference({ versionType: 'exact' }),
11351135
cxApi,
11361136
'@aws-cdk/region-info',
@@ -1541,7 +1541,7 @@ const integRunner = configureProject(
15411541
description: 'CDK Integration Testing Tool',
15421542
srcdir: 'lib',
15431543
deps: [
1544-
cloudAssemblySchema.customizeReference({ versionType: 'exact' }),
1544+
cloudAssemblySchema.customizeReference({ versionType: 'minimal' }),
15451545
cxApi,
15461546
cdkCliWrapper.customizeReference({ versionType: 'exact' }),
15471547
cli.customizeReference({ versionType: 'exact' }),

packages/@aws-cdk/integ-runner/.projen/tasks.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/aws-cdk/.projen/tasks.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/cdk-assets/.projen/tasks.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)