refactor(toolkit-lib): remove shared-private.ts and update references (#531)

This PR removes the shared-private.ts file and updates all references to
it across the toolkit-lib package.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

Author: mrgrain

packages/@aws-cdk/toolkit-lib/lib/api/aws-auth/types.ts

@@ -1,6 +1,6 @@
 import type { SDKv3CompatibleCredentialProvider } from '@aws-cdk/cli-plugin-contract';
-import type { SdkProviderServices } from '../shared-private';
-import { AwsCliCompatible } from '../shared-private';
+import { AwsCliCompatible } from './awscli-compatible';
+import type { SdkProviderServices } from './sdk-provider';
 
 /**
  * Options for the default SDK provider

packages/@aws-cdk/toolkit-lib/lib/api/cloud-assembly/private/prepare-source.ts

@@ -6,10 +6,11 @@ import * as cxschema from '@aws-cdk/cloud-assembly-schema';
 import * as cxapi from '@aws-cdk/cx-api';
 import * as fs from 'fs-extra';
 import { lte } from 'semver';
-import type { SdkProvider, IoHelper } from '../../../api/shared-private';
 import type { ToolkitServices } from '../../../toolkit/private';
 import { ToolkitError } from '../../../toolkit/toolkit-error';
 import { splitBySize, versionNumber } from '../../../util';
+import type { SdkProvider } from '../../aws-auth/private';
+import type { IoHelper } from '../../io/private';
 import { IO } from '../../io/private';
 import type { IReadLock, IWriteLock } from '../../rwlock';
 import { RWLock } from '../../rwlock';

packages/@aws-cdk/toolkit-lib/lib/api/cloud-assembly/private/stack-assembly.ts

@@ -1,7 +1,7 @@
 import '../../../private/dispose-polyfill';
 import { major } from 'semver';
 import { ToolkitError } from '../../../toolkit/toolkit-error';
-import type { IoHelper } from '../../shared-private';
+import type { IoHelper } from '../../io/private';
 import { BaseStackAssembly, ExtendedStackSelection as CliExtendedStackSelection } from '../stack-assembly';
 import { StackCollection } from '../stack-collection';
 import type { StackSelector } from '../stack-selector';

packages/@aws-cdk/toolkit-lib/lib/api/shared-private.ts

@@ -1,8 +1,9 @@
 
+import type { SdkProvider } from '../../api/aws-auth/private';
 import type { ICloudAssemblySource } from '../../api/cloud-assembly';
 import { StackAssembly } from '../../api/cloud-assembly/private';
+import type { IoHelper } from '../../api/io/private';
 import type { PluginHost } from '../../api/plugin';
-import type { SdkProvider, IoHelper } from '../../api/shared-private';
 
 /**
  * Helper struct to pass internal services around.

packages/@aws-cdk/toolkit-lib/lib/toolkit/private/index.ts

@@ -12,7 +12,7 @@ import { bold } from 'chalk';
 
 import type { BootstrapOptions } from '../../lib/actions/bootstrap';
 import { BootstrapEnvironments, BootstrapSource, BootstrapStackParameters } from '../../lib/actions/bootstrap';
-import { SdkProvider } from '../../lib/api/shared-private';
+import { SdkProvider } from '../../lib/api/aws-auth/private';
 import { Toolkit } from '../../lib/toolkit/toolkit';
 import { TestIoHost, builderFixture, disposableCloudAssemblySource } from '../_helpers';
 import {

packages/@aws-cdk/toolkit-lib/test/actions/bootstrap.test.ts

@@ -4,7 +4,7 @@ import { DiffMethod } from '../../lib/actions/diff';
 import * as awsauth from '../../lib/api/aws-auth/private';
 import { StackSelectionStrategy } from '../../lib/api/cloud-assembly';
 import * as deployments from '../../lib/api/deployments';
-import { cfnApi } from '../../lib/api/shared-private';
+import * as cfnApi from '../../lib/api/deployments/cfn-api';
 import { Toolkit } from '../../lib/toolkit';
 import { builderFixture, disposableCloudAssemblySource, TestIoHost } from '../_helpers';
 import { MockSdk, restoreSdkMocksToDefault, setDefaultSTSMocks } from '../_helpers/mock-sdk';

packages/@aws-cdk/toolkit-lib/test/actions/diff.test.ts

@@ -1,6 +1,6 @@
 import { GetTemplateCommand, ListStacksCommand } from '@aws-sdk/client-cloudformation';
 import { StackSelectionStrategy, Toolkit } from '../../lib';
-import { SdkProvider } from '../../lib/api/shared-private';
+import { SdkProvider } from '../../lib/api/aws-auth/private';
 import { builderFixture, TestIoHost } from '../_helpers';
 import { mockCloudFormationClient, MockSdk } from '../_helpers/mock-sdk';
 

packages/@aws-cdk/toolkit-lib/test/actions/refactor.test.ts

@@ -1,7 +1,7 @@
 import * as path from 'path';
 import * as fs from 'fs-extra';
 import { RWLock } from '../../../lib/api/rwlock';
-import { contextproviders } from '../../../lib/api/shared-private';
+import * as contextproviders from '../../../lib/context-providers';
 import { Toolkit } from '../../../lib/toolkit/toolkit';
 import { ToolkitError } from '../../../lib/toolkit/toolkit-error';
 import { appFixture, appFixtureConfig, autoCleanOutDir, builderFixture, builderFunctionFromFixture, cdkOutFixture, TestIoHost } from '../../_helpers';

packages/@aws-cdk/toolkit-lib/test/api/cloud-assembly/source-builder.test.ts

@@ -14,9 +14,9 @@ import {
 import { GetParameterCommand } from '@aws-sdk/client-ssm';
 import { CloudFormationStack } from '../../../lib/api/cloudformation';
 import { Deployments } from '../../../lib/api/deployments';
+import * as cfnApi from '../../../lib/api/deployments/cfn-api';
 import { deployStack } from '../../../lib/api/deployments/deploy-stack';
 import { HotswapMode } from '../../../lib/api/hotswap';
-import { cfnApi } from '../../../lib/api/shared-private';
 import { ToolkitInfo } from '../../../lib/api/toolkit-info';
 import { testStack } from '../../_helpers/assembly';
 import {

packages/@aws-cdk/toolkit-lib/test/api/deployments/cloudformation-deployments.test.ts

@@ -1,5 +1,5 @@
+import { SdkProvider } from '../../lib/api/aws-auth/private';
 import { BaseCredentials } from '../../lib/api/aws-auth/types';
-import { SdkProvider } from '../../lib/api/shared-private';
 import { Toolkit } from '../../lib/toolkit/toolkit';
 import { appFixture, TestIoHost } from '../_helpers';
 import { MockSdk } from '../_helpers/mock-sdk';

packages/@aws-cdk/toolkit-lib/test/toolkit/base-credentials.test.ts

@@ -1,6 +1,6 @@
 import type { PluginProviderResult } from '@aws-cdk/cli-plugin-contract';
 import { StackSelectionStrategy } from '../../lib';
-import { SdkProvider } from '../../lib/api/shared-private';
+import { SdkProvider } from '../../lib/api/aws-auth/private';
 import { Toolkit } from '../../lib/toolkit/toolkit';
 import { appFixture, TestIoHost } from '../_helpers';
 import { MockSdk } from '../_helpers/mock-sdk';