You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(cli): cannot set progress via app or user configuration (#231)
In [v2.172.0](https://github.com/aws/aws-cdk/releases/tag/v2.172.0) (via
aws/aws-cdk@069b72c)
we accidentally broke the "bar" stack activity progress output mode (*).
Turns out no-one noticed.
In
[v2.1002.0](https://github.com/aws/aws-cdk-cli/releases/tag/aws-cdk%40v2.1002.0)
(via
0d9912f)
this got unintentionally fixed and the `--progress` was honored again.
However the accidental fix didn't consider options set by app or user
configuration. Again noone really noticed, until this week a user
alerted my to the issue on the cdk.dev Slack.
This PR fixes `progress` set via app or user configuration.
(*) This line is the culprit:
aws/aws-cdk@069b72c#diff-d03bd87f399ba5824d5442aa691df8b6f08f4f8a3848cfc8492c3d52fab5e48bR105
Previously "default" verbosity was a `0`, which meant `verbose = 0` and
later on `!verbose` would turn into `true`.
The change caused `verbose` to be a value different than `0` and thus
turning `!verbose` to be `false` and the code would always assume we are
in verbose logging mode and must use the "events" progress.
---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
0 commit comments