Skip to content

Commit 035c527

Browse files
authored
chore(cli): remove unused destroy options (#196)
These are not used downstream, so let's remove them for clarity. Note that low-level force destroy is a thing in CFN and we _might_ reintroduce this later. It's basically about abandoning failed resources. But we currently don't support it, so let's not bother. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
1 parent f59332f commit 035c527

File tree

6 files changed

+1
-19
lines changed

6 files changed

+1
-19
lines changed

packages/@aws-cdk/toolkit-lib/lib/actions/destroy/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export interface DestroyOptions {
1414
/**
1515
* Change stack watcher output to CI mode.
1616
*
17-
* @deprecated Implement in IoHost instead
17+
* @deprecated has no effect, please implement in IoHost instead
1818
*/
1919
readonly ci?: boolean;
2020
}

packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts

-1
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,6 @@ export class Toolkit extends CloudAssemblySourceBuilder implements AsyncDisposab
738738
stack,
739739
deployName: stack.stackName,
740740
roleArn: options.roleArn,
741-
ci: options.ci,
742741
});
743742
await ioHost.notify(success(`\n ✅ ${chalk.blue(stack.displayName)}: ${action}ed`));
744743
} catch (e) {

packages/aws-cdk/lib/api/deployments/deploy-stack.ts

-2
Original file line numberDiff line numberDiff line change
@@ -664,8 +664,6 @@ export interface DestroyStackOptions {
664664
sdk: SDK;
665665
roleArn?: string;
666666
deployName?: string;
667-
quiet?: boolean;
668-
ci?: boolean;
669667
}
670668

671669
export async function destroyStack(options: DestroyStackOptions, { ioHost, action }: IoMessaging) {

packages/aws-cdk/lib/api/deployments/deployments.ts

-5
Original file line numberDiff line numberDiff line change
@@ -278,9 +278,6 @@ export interface DestroyStackOptions {
278278
stack: cxapi.CloudFormationStackArtifact;
279279
deployName?: string;
280280
roleArn?: string;
281-
quiet?: boolean;
282-
force?: boolean;
283-
ci?: boolean;
284281
}
285282

286283
export interface StackExistsOptions {
@@ -590,8 +587,6 @@ export class Deployments {
590587
roleArn: executionRoleArn,
591588
stack: options.stack,
592589
deployName: options.deployName,
593-
quiet: options.quiet,
594-
ci: options.ci,
595590
}, { ioHost: this.ioHost, action: this.action });
596591
}
597592

packages/aws-cdk/lib/cli/cdk-toolkit.ts

-9
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,6 @@ export class CdkToolkit {
382382
force: true,
383383
roleArn: options.roleArn,
384384
fromDeploy: true,
385-
ci: options.ci,
386385
});
387386
}
388387
return;
@@ -857,7 +856,6 @@ export class CdkToolkit {
857856
stack,
858857
deployName: stack.stackName,
859858
roleArn: options.roleArn,
860-
ci: options.ci,
861859
});
862860
success(`\n ✅ %s: ${action}ed`, chalk.blue(stack.displayName));
863861
} catch (e) {
@@ -1699,13 +1697,6 @@ export interface DestroyOptions {
16991697
* Whether the destroy request came from a deploy.
17001698
*/
17011699
fromDeploy?: boolean;
1702-
1703-
/**
1704-
* Whether we are on a CI system
1705-
*
1706-
* @default false
1707-
*/
1708-
readonly ci?: boolean;
17091700
}
17101701

17111702
/**

packages/aws-cdk/lib/cli/cli.ts

-1
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,6 @@ export async function exec(args: string[], synthesizer?: Synthesizer): Promise<n
428428
exclusively: args.exclusively,
429429
force: args.force,
430430
roleArn: args.roleArn,
431-
ci: args.ci,
432431
});
433432

434433
case 'gc':

0 commit comments

Comments
 (0)