From 64d5e96de9e3b6f4bf854eef1c9279de56106085 Mon Sep 17 00:00:00 2001 From: zirkelc Date: Thu, 28 Nov 2024 07:53:56 +0100 Subject: [PATCH 1/4] feat(logger): change visibility to protected --- packages/logger/src/Logger.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/logger/src/Logger.ts b/packages/logger/src/Logger.ts index 3244eefac9..73ed803254 100644 --- a/packages/logger/src/Logger.ts +++ b/packages/logger/src/Logger.ts @@ -115,7 +115,7 @@ class Logger extends Utility implements LoggerInterface { /** * JSON indentation used to format the logs. */ - private logIndentation: number = LogJsonIndent.COMPACT; + protected logIndentation: number = LogJsonIndent.COMPACT; /** * Log level used internally by the current instance of Logger. */ @@ -700,7 +700,7 @@ class Logger extends Utility implements LoggerInterface { * @param input - The main input of the log item, this can be a string or an object with additional attributes * @param extraInput - Additional attributes to be added to the log item */ - private createAndPopulateLogItem( + protected createAndPopulateLogItem( logLevel: number, input: LogItemMessage, extraInput: LogItemExtraInput @@ -783,7 +783,7 @@ class Logger extends Utility implements LoggerInterface { * * @param logLevel - The log level to get the name of */ - private getLogLevelNameFromNumber(logLevel: number): Uppercase { + protected getLogLevelNameFromNumber(logLevel: number): Uppercase { let found: Uppercase | undefined; for (const [key, value] of Object.entries(LogLevelThreshold)) { if (value === logLevel) { @@ -835,7 +835,7 @@ class Logger extends Utility implements LoggerInterface { * @param logLevel - The log level * @param log - The log item to print */ - private printLog(logLevel: number, log: LogItem): void { + protected printLog(logLevel: number, log: LogItem): void { log.prepareForPrint(); const consoleMethod = @@ -862,7 +862,7 @@ class Logger extends Utility implements LoggerInterface { * @param input - The log message * @param extraInput - The extra input to log */ - private processLogItem( + protected processLogItem( logLevel: number, input: LogItemMessage, extraInput: LogItemExtraInput From 6012df9c0e5b590aea2899c08bfbb8615990efe1 Mon Sep 17 00:00:00 2001 From: zirkelc Date: Thu, 28 Nov 2024 07:59:17 +0100 Subject: [PATCH 2/4] feat(logger): todo --- packages/logger/src/Logger.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/logger/src/Logger.ts b/packages/logger/src/Logger.ts index 73ed803254..aea6469a63 100644 --- a/packages/logger/src/Logger.ts +++ b/packages/logger/src/Logger.ts @@ -846,6 +846,7 @@ class Logger extends Utility implements LoggerInterface { 'critical' >); + // TODO: make this.console protected or create getConsole/getConsoleMethod? this.console[consoleMethod]( JSON.stringify( log.getAttributes(), From 6d4eacb19f04a53b6ae0a0144cd01e14db1e946d Mon Sep 17 00:00:00 2001 From: zirkelc Date: Thu, 28 Nov 2024 13:59:16 +0100 Subject: [PATCH 3/4] revert: protected --- packages/logger/src/Logger.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/logger/src/Logger.ts b/packages/logger/src/Logger.ts index aea6469a63..3826c31eaf 100644 --- a/packages/logger/src/Logger.ts +++ b/packages/logger/src/Logger.ts @@ -115,7 +115,7 @@ class Logger extends Utility implements LoggerInterface { /** * JSON indentation used to format the logs. */ - protected logIndentation: number = LogJsonIndent.COMPACT; + private logIndentation: number = LogJsonIndent.COMPACT; /** * Log level used internally by the current instance of Logger. */ @@ -783,7 +783,7 @@ class Logger extends Utility implements LoggerInterface { * * @param logLevel - The log level to get the name of */ - protected getLogLevelNameFromNumber(logLevel: number): Uppercase { + private getLogLevelNameFromNumber(logLevel: number): Uppercase { let found: Uppercase | undefined; for (const [key, value] of Object.entries(LogLevelThreshold)) { if (value === logLevel) { From 42d77086df14a734e7425b8e3960605d110c7df0 Mon Sep 17 00:00:00 2001 From: zirkelc Date: Thu, 28 Nov 2024 14:04:14 +0100 Subject: [PATCH 4/4] revert: remove comment --- packages/logger/src/Logger.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/logger/src/Logger.ts b/packages/logger/src/Logger.ts index 3826c31eaf..69e84184c2 100644 --- a/packages/logger/src/Logger.ts +++ b/packages/logger/src/Logger.ts @@ -846,7 +846,6 @@ class Logger extends Utility implements LoggerInterface { 'critical' >); - // TODO: make this.console protected or create getConsole/getConsoleMethod? this.console[consoleMethod]( JSON.stringify( log.getAttributes(),