From de1c10409dbb8fd033d1d16afcc61ecc98a76628 Mon Sep 17 00:00:00 2001 From: John Harlow Date: Wed, 20 Nov 2024 16:48:50 -0800 Subject: [PATCH 1/3] fix(parser): properly parse eventbridge envelope when using safeParse Currently, the EventBridgeEnvelope.safeParse method only validates, it does not parse the data provided in the typing system. Small fix utilizing existing typing generics that weren't being assigned. --- packages/parser/src/envelopes/envelope.ts | 2 +- packages/parser/src/envelopes/event-bridge.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/parser/src/envelopes/envelope.ts b/packages/parser/src/envelopes/envelope.ts index df802b65af..85cdef225f 100644 --- a/packages/parser/src/envelopes/envelope.ts +++ b/packages/parser/src/envelopes/envelope.ts @@ -35,7 +35,7 @@ const Envelope = { * @param input * @param schema */ - safeParse(input: unknown, schema: T): ParsedResult { + safeParse(input: unknown, schema: T): ParsedResult> { try { if (typeof input !== 'object' && typeof input !== 'string') { return { diff --git a/packages/parser/src/envelopes/event-bridge.ts b/packages/parser/src/envelopes/event-bridge.ts index 84f87f10db..20eae70827 100644 --- a/packages/parser/src/envelopes/event-bridge.ts +++ b/packages/parser/src/envelopes/event-bridge.ts @@ -17,7 +17,7 @@ export const EventBridgeEnvelope = { return Envelope.parse(EventBridgeSchema.parse(data).detail, schema); }, - safeParse(data: unknown, schema: T): ParsedResult { + safeParse(data: unknown, schema: T): ParsedResult> { const parsedEnvelope = EventBridgeSchema.safeParse(data); if (!parsedEnvelope.success) { From b8081bea295ef8977794fd64e5831efeaa266df2 Mon Sep 17 00:00:00 2001 From: John Harlow Date: Thu, 21 Nov 2024 21:28:36 -0800 Subject: [PATCH 2/3] fix(parser): properly parse lambdafunctionurl envelope when using safeParse --- packages/parser/src/envelopes/lambda.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/parser/src/envelopes/lambda.ts b/packages/parser/src/envelopes/lambda.ts index ddee609064..91d609646f 100644 --- a/packages/parser/src/envelopes/lambda.ts +++ b/packages/parser/src/envelopes/lambda.ts @@ -23,7 +23,7 @@ export const LambdaFunctionUrlEnvelope = { return Envelope.parse(parsedEnvelope.body, schema); }, - safeParse(data: unknown, schema: T): ParsedResult { + safeParse(data: unknown, schema: T): ParsedResult> { const parsedEnvelope = LambdaFunctionUrlSchema.safeParse(data); if (!parsedEnvelope.success) { From fd9d36e32fddb18b2535184ac45a7107a2bd055e Mon Sep 17 00:00:00 2001 From: John Harlow Date: Thu, 21 Nov 2024 21:28:56 -0800 Subject: [PATCH 3/3] fix(parser): properly parse vpclattice envelopes when using safeParse --- packages/parser/src/envelopes/vpc-lattice.ts | 2 +- packages/parser/src/envelopes/vpc-latticev2.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/parser/src/envelopes/vpc-lattice.ts b/packages/parser/src/envelopes/vpc-lattice.ts index c4665dca73..64d031c668 100644 --- a/packages/parser/src/envelopes/vpc-lattice.ts +++ b/packages/parser/src/envelopes/vpc-lattice.ts @@ -20,7 +20,7 @@ export const VpcLatticeEnvelope = { return Envelope.parse(parsedEnvelope.body, schema); }, - safeParse(data: unknown, schema: T): ParsedResult { + safeParse(data: unknown, schema: T): ParsedResult> { const parsedEnvelope = VpcLatticeSchema.safeParse(data); if (!parsedEnvelope.success) { return { diff --git a/packages/parser/src/envelopes/vpc-latticev2.ts b/packages/parser/src/envelopes/vpc-latticev2.ts index caeedf650a..8a40f0f927 100644 --- a/packages/parser/src/envelopes/vpc-latticev2.ts +++ b/packages/parser/src/envelopes/vpc-latticev2.ts @@ -19,7 +19,7 @@ export const VpcLatticeV2Envelope = { return Envelope.parse(parsedEnvelope.body, schema); }, - safeParse(data: unknown, schema: T): ParsedResult { + safeParse(data: unknown, schema: T): ParsedResult> { const parsedEnvelope = VpcLatticeV2Schema.safeParse(data); if (!parsedEnvelope.success) { return {