docs(idempotency): add callout about undefined early return #3055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
documentation
pull-request-size
bot
added
size/M
dreamorosi
force-pushed
the
docs/idempotency_early-return
branch
from
e873720 to
5a4571e
Compare
pull-request-size
bot
added
size/S
leandrodamascena
previously approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Hey @dreamorosi! I'm approving this PR, feel free to accept or not my suggestions.
Co-authored-by: Leandro Damascena <[email protected]>
leandrodamascena
approved these changes
Sep 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR adds a callout and link to the Middy.js repo in the docs related to the Idempotency
makeHandlerIdempotentMiddy.js middleware to specify that the AWS Lambda function handler must return a value different thanundefinedfor the middleware to work correctly.Issue number: closes #2987
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.