From 8410dd107313c49ca8c8ecb038a9af16ac00496f Mon Sep 17 00:00:00 2001 From: Alexander Schueren Date: Wed, 24 Apr 2024 11:31:08 +0200 Subject: [PATCH 1/3] set etag optional, for delete object notifications --- packages/parser/src/schemas/s3.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/parser/src/schemas/s3.ts b/packages/parser/src/schemas/s3.ts index 558776ffa5..202a2b8e80 100644 --- a/packages/parser/src/schemas/s3.ts +++ b/packages/parser/src/schemas/s3.ts @@ -73,7 +73,7 @@ const S3EventNotificationEventBridgeDetailSchema = z.object({ object: z.object({ key: z.string(), size: z.number().nonnegative().optional(), - etag: z.string(), + etag: z.string().optional(), 'version-id': z.string().optional(), sequencer: z.string().optional(), }), From 43570da683a11925e0fddfbfa8d1e2d1fb7c4dcf Mon Sep 17 00:00:00 2001 From: Alexander Schueren Date: Wed, 24 Apr 2024 11:38:05 +0200 Subject: [PATCH 2/3] remove etag and size from the test event --- .../events/s3EventBridgeNotificationObjectDeletedEvent.json | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/parser/tests/events/s3EventBridgeNotificationObjectDeletedEvent.json b/packages/parser/tests/events/s3EventBridgeNotificationObjectDeletedEvent.json index af52ee2fef..8006b93e40 100644 --- a/packages/parser/tests/events/s3EventBridgeNotificationObjectDeletedEvent.json +++ b/packages/parser/tests/events/s3EventBridgeNotificationObjectDeletedEvent.json @@ -16,8 +16,6 @@ }, "object": { "key": "IMG_m7fzo3.jpg", - "size": 184662, - "etag": "4e68adba0abe2dc8653dc3354e14c01d", "sequencer": "006408CAD69598B05E" }, "request-id": "0BH729840619AG5K", From c3fa9a6a1a8e32b4a790f9887faa0c71e83dfb74 Mon Sep 17 00:00:00 2001 From: Alexander Schueren Date: Wed, 24 Apr 2024 12:22:14 +0200 Subject: [PATCH 3/3] add comment why etag and size is optional --- packages/parser/src/schemas/s3.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/parser/src/schemas/s3.ts b/packages/parser/src/schemas/s3.ts index 202a2b8e80..ccc8fca155 100644 --- a/packages/parser/src/schemas/s3.ts +++ b/packages/parser/src/schemas/s3.ts @@ -72,8 +72,8 @@ const S3EventNotificationEventBridgeDetailSchema = z.object({ }), object: z.object({ key: z.string(), - size: z.number().nonnegative().optional(), - etag: z.string().optional(), + size: z.number().nonnegative().optional(), // not present in DeleteObject events + etag: z.string().optional(), // not present in DeleteObject events 'version-id': z.string().optional(), sequencer: z.string().optional(), }),