diff --git a/packages/tracer/src/Tracer.ts b/packages/tracer/src/Tracer.ts index adb4f3b92d..434c0d0f2c 100644 --- a/packages/tracer/src/Tracer.ts +++ b/packages/tracer/src/Tracer.ts @@ -410,7 +410,8 @@ class Tracer extends Utility implements TracerInterface { subsegment?.close(); } catch (error) { console.warn( - `Failed to close or serialize segment, ${subsegment?.name}. We are catching the error but data might be lost.`, + `Failed to close or serialize segment %s. We are catching the error but data might be lost.`, + subsegment?.name, error ); } @@ -499,7 +500,8 @@ class Tracer extends Utility implements TracerInterface { subsegment?.close(); } catch (error) { console.warn( - `Failed to close or serialize segment, ${subsegment?.name}. We are catching the error but data might be lost.`, + `Failed to close or serialize segment %s. We are catching the error but data might be lost.`, + subsegment?.name, error ); } diff --git a/packages/tracer/src/middleware/middy.ts b/packages/tracer/src/middleware/middy.ts index cc0477f01f..547561500f 100644 --- a/packages/tracer/src/middleware/middy.ts +++ b/packages/tracer/src/middleware/middy.ts @@ -74,7 +74,8 @@ const captureLambdaHandler = ( handlerSegment.close(); } catch (error) { console.warn( - `Failed to close or serialize segment, ${handlerSegment.name}. We are catching the error but data might be lost.`, + `Failed to close or serialize segment %s. We are catching the error but data might be lost.`, + handlerSegment.name, error ); } diff --git a/packages/tracer/tests/unit/Tracer.test.ts b/packages/tracer/tests/unit/Tracer.test.ts index df6838ad13..18eb37d24a 100644 --- a/packages/tracer/tests/unit/Tracer.test.ts +++ b/packages/tracer/tests/unit/Tracer.test.ts @@ -953,7 +953,8 @@ describe('Class: Tracer', () => { expect(closeSpy).toHaveBeenCalledTimes(1); expect(logWarningSpy).toHaveBeenNthCalledWith( 1, - `Failed to close or serialize segment, ${handlerSubsegment.name}. We are catching the error but data might be lost.`, + `Failed to close or serialize segment %s. We are catching the error but data might be lost.`, + handlerSubsegment.name, new Error('dummy error') ); }); @@ -1414,7 +1415,8 @@ describe('Class: Tracer', () => { expect(closeSpy).toHaveBeenCalledTimes(1); expect(logWarningSpy).toHaveBeenNthCalledWith( 1, - `Failed to close or serialize segment, ${handlerSubsegment.name}. We are catching the error but data might be lost.`, + `Failed to close or serialize segment %s. We are catching the error but data might be lost.`, + handlerSubsegment.name, new Error('dummy error') ); }); diff --git a/packages/tracer/tests/unit/middy.test.ts b/packages/tracer/tests/unit/middy.test.ts index dc7af9d553..c470b1d25a 100644 --- a/packages/tracer/tests/unit/middy.test.ts +++ b/packages/tracer/tests/unit/middy.test.ts @@ -405,7 +405,8 @@ describe('Middy middleware', () => { expect(closeSpy).toHaveBeenCalledTimes(1); expect(logWarningSpy).toHaveBeenNthCalledWith( 1, - `Failed to close or serialize segment, ${handlerSubsegment.name}. We are catching the error but data might be lost.`, + `Failed to close or serialize segment %s. We are catching the error but data might be lost.`, + handlerSubsegment.name, new Error('dummy error') ); // Check that the segments are restored