refactor(parameters): move table seeding into AwsCustomResource
#1317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
As explained in the linked issue (#1315), the current implementation of the tests relies on the AWS SDK to seed the DynamoDB Tables created as part of
DynamoDBProvider
's integration tests. These inserts are done as part of the setup stage (beforeAll
in Jest). This means that the IAM role/identity used is the one assumed by the GitHub Actions worker and obtained via OIDC connector.In order to avoid granting additional permissions to the role assumed by the GitHub Actions worker, this moves the
PutItem
actions in a series of CDK-managed custom resources so that they are performed as part of the stack deployment and using the same role assumed by CDK itself.Once merged this PR will close #1315.
How to verify this change
See successful result of integration tests:

Related issues, RFCs
Issue number: #1315
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.